fasta2a: be more strict on agent card (#1781)

Author: Kludex

fasta2a/fasta2a/applications.py

@@ -12,7 +12,16 @@
 from starlette.types import ExceptionHandler, Lifespan, Receive, Scope, Send
 
 from .broker import Broker
-from .schema import AgentCard, Capabilities, Provider, Skill, a2a_request_ta, a2a_response_ta, agent_card_ta
+from .schema import (
+    AgentCard,
+    Authentication,
+    Capabilities,
+    Provider,
+    Skill,
+    a2a_request_ta,
+    a2a_response_ta,
+    agent_card_ta,
+)
 from .storage import Storage
 from .task_manager import TaskManager
 
@@ -82,12 +91,13 @@ async def _agent_card_endpoint(self, request: Request) -> Response:
                 default_input_modes=self.default_input_modes,
                 default_output_modes=self.default_output_modes,
                 capabilities=Capabilities(streaming=False, push_notifications=False, state_transition_history=False),
+                authentication=Authentication(schemes=[]),
             )
             if self.description is not None:
                 agent_card['description'] = self.description
             if self.provider is not None:
                 agent_card['provider'] = self.provider
-            self._agent_card_json_schema = agent_card_ta.dump_json(agent_card)
+            self._agent_card_json_schema = agent_card_ta.dump_json(agent_card, by_alias=True)
         return Response(content=self._agent_card_json_schema, media_type='application/json')
 
     async def _agent_run_endpoint(self, request: Request) -> Response:

fasta2a/fasta2a/schema.py

@@ -41,8 +41,7 @@ class AgentCard(TypedDict):
     capabilities: Capabilities
     """The capabilities of the agent."""
 
-    # TODO(Marcelo): The spec makes authentication required.
-    authentication: NotRequired[Authentication]
+    authentication: Authentication
     """The authentication schemes supported by the agent.
 
     Intended to match OpenAPI authentication structure.

tests/fasta2a/test_applications.py

@@ -0,0 +1,45 @@
+from __future__ import annotations as _annotations
+
+from contextlib import asynccontextmanager
+
+import httpx
+import pytest
+from asgi_lifespan import LifespanManager
+from inline_snapshot import snapshot
+
+from ..conftest import try_import
+
+with try_import() as imports_successful:
+    from fasta2a.applications import FastA2A
+    from fasta2a.broker import InMemoryBroker
+    from fasta2a.storage import InMemoryStorage
+
+
+pytestmark = [pytest.mark.anyio, pytest.mark.skipif(not imports_successful(), reason='fasta2a not installed')]
+
+
+@asynccontextmanager
+async def create_test_client(app: FastA2A):
+    async with LifespanManager(app=app) as manager:
+        transport = httpx.ASGITransport(app=manager.app)
+        async with httpx.AsyncClient(transport=transport, base_url='http://testclient') as client:
+            yield client
+
+
+async def test_agent_card():
+    app = FastA2A(storage=InMemoryStorage(), broker=InMemoryBroker())
+    async with create_test_client(app) as client:
+        response = await client.get('/.well-known/agent.json')
+        assert response.status_code == 200
+        assert response.json() == snapshot(
+            {
+                'name': 'Agent',
+                'url': 'http://localhost:8000',
+                'version': '1.0.0',
+                'skills': [],
+                'defaultInputModes': ['application/json'],
+                'defaultOutputModes': ['application/json'],
+                'capabilities': {'streaming': False, 'pushNotifications': False, 'stateTransitionHistory': False},
+                'authentication': {'schemes': []},
+            }
+        )