implicitly_convertible with custom types

[mathisloge]

Hey,
according to https://pybind11.readthedocs.io/en/stable/advanced/classes.html#implicit-conversions
I can define an implicitly_convertible operation, when the OutputType has an constructor with the InputType.
In my case I've defined:

class ObjectQueryBuilder;
struct ObjectQuery
{
// datamembers

    ObjectQuery() = default;
    ObjectQuery(const ObjectQuery &other) = default;
    ObjectQuery(ObjectQuery &&other) noexcept = default;
    ObjectQuery &operator=(const ObjectQuery &other) = default;
    ObjectQuery &operator=(ObjectQuery &&other) noexcept = default;
    ObjectQuery(const ObjectQueryBuilder &builder); <==== Conversion constructor
    ~ObjectQuery() = default;
};

class QUITE_CORE_EXPORT ObjectQueryBuilder
{
    std::shared_ptr<ObjectQuery> query_;

  public:
    ObjectQueryBuilder();
... more functions
  private:
    friend ObjectQuery;
};

In my bindings I register them both:

py::class_<quite::ObjectQuery> py_object_query(m, "ObjectQuery");
py::class_<quite::ObjectQueryBuilder>(m, "ObjectQueryBuilder")
        .def(py::init<>())
        .def(....more functions....);
py::implicitly_convertible<quite::ObjectQueryBuilder, quite::ObjectQuery>();

But I still get

[ctest] >       btn = app.find_object(hello_btn_query)
[ctest] E       TypeError: find_object(): incompatible function arguments. The following argument types are supported:
[ctest] E           1. (self: quite._quite.Probe, object_query: quite::ObjectQuery) -> quite._quite.RemoteObject
[ctest] E       
[ctest] E       Invoked with: <quite._quite.Probe object at 0x7f09ad284330>, <quite._quite.ObjectQueryBuilder object at 0x7f09ad287970>

The function call find_object has the signature RemoteObject Probe::find_object(ObjectQuery query) and is registered in python with

    py_probe //
        .def("find_object",
             &Probe::find_object,
             py::arg{"object_query"},)

Is there anything I've misunderstood?

[mathisloge]

Written the text and directly found my issue :D

I've forgotten to declare the conversion constructor py_object_query.def(py::init<quite::ObjectQueryBuilder>());