PYBIND11_MASTER_PROJECT Can the cmake variable be updated? #4159
-
|
@rwgk @henryiii @Skylion007 How hard would it be to change PYBIND11_MASTER_PROJECT to something else like PYBIND11_MAIN_PROJECT or PYBIND11_PRIMARY_PROJECT? This is a usage in conflict with the words matter updates on our side, but we're unsure of what the full usage is in the pybind11 project and would like to gather more information. |
Beta Was this translation helpful? Give feedback.
Replies: 4 comments
-
|
Pretty sure that's very much a private variable for us. It's a way for our CMake file to tell if it's the currently running project or if it's running as a submodule. While we have enough users that anything is possible, people should in theory not be reading or writing to that variable. |
Beta Was this translation helpful? Give feedback.
-
|
Understood. I leave the decision up to you as to whether you want to make the change or not, but would very much appreciate if you would provide an answer either way. There are additional hits with |
Beta Was this translation helpful? Give feedback.
-
|
Based on what @henryiii wrote about github auto-redirects from master to main, I'm in making the move soon, anytime. I think it'll be the least effort to get the move from master to main done first, then mop up the rest straightaway, or even in the same step. |
Beta Was this translation helpful? Give feedback.
-
|
This sounds good to me. Thanks so much! |
Beta Was this translation helpful? Give feedback.
Based on what @henryiii wrote about github auto-redirects from master to main, I'm in making the move soon, anytime.
I think it'll be the least effort to get the move from master to main done first, then mop up the rest straightaway, or even in the same step.