Fix #156 - Installation errors in windows (#157)

- Fix the permissions errors in datasets.download_pysteps_data and datasets.download_mrms_data functions (#156).

- Update the installation instructions for Windows systems.

Author: aperezhortal

doc/source/user_guide/set_pystepsrc.rst

@@ -46,9 +46,10 @@ following order:
   pystepsrc file inside that directory.
 - **$HOME/.pysteps/pystepsrc** (Unix and Mac OS X) : If the system variable $HOME is defined, it looks
   for the configuration file in this path.
-- **$USERPROFILE/pysteps/pystepsrc** (Windows only): It looks for the configuration file
-  in the pysteps directory located user's home directory.
-- Lastly, it looks inside the library in *pysteps/pystepsrc* for a
+- **%USERPROFILE%\\pysteps\\pystepsrc** (Windows only): It looks for the configuration file
+  in the pysteps directory located user's home directory (indicated by the %USERPROFILE%
+  system variable).
+- Lastly, it looks inside the library in *pysteps\\pystepsrc* for a
   system-defined copy.
 
 The recommended method to setup the configuration files is to edit a copy
@@ -73,15 +74,14 @@ need to create the directory if it does not exist. In a terminal, run::
 
     $ mkdir -p ${HOME}/.pysteps
 
-The next step is to find the location of the library's pystepsrc file being
-actually used.
+The next step is to find the location of the library's default pystepsrc file.
 When we import pysteps in a python interpreter, the configuration file loaded
 is shown::
 
     import pysteps
     "Pysteps configuration file found at: /path/to/pysteps/library/pystepsrc"
 
-Then we copy the library's default rc file to that directory::
+Then we copy the library's default configuration file to that directory::
 
     $ cp /path/to/pysteps/library/pystepsrc ${HOME}/.pysteps/pystepsrc
 
@@ -98,26 +98,36 @@ Windows
 ~~~~~~~
 
 For windows users, the recommended way to customize the pySTEPS
-configuration is placing the pystepsrc parameters file in the users folder
+configuration is placing the pystepsrc parameters file in the users' folder
 (defined in the %USERPROFILE% environment variable) in the following path:
-**%USERPROFILE%/pysteps/pystepsrc**
+**%USERPROFILE%\\pysteps\\pystepsrc**
 
-To steps to setup up the configuration file in the home directory first we
-need to create the directory if it does not exist. In a terminal, run::
+To setup up the configuration file in the home directory first, we
+need to create the directory if it does not exist. In a **windows terminal**, run::
+
+    $ mkdir %USERPROFILE%\pysteps
+
+**Important**
+
+It was reported that the %USERPROFILE% variable may be interpreted as an string
+literal when the anaconda terminal is used.
+This will result in a '%USERPROFILE%' folder being created in the current working directory
+instead of the desired pysteps folder in the user's home.
+If that is the case, use the explicit path to your home folder instead of `%USERPROFILE%`.
+For example::
 
-    $ mkdir -p %USERPROFILE%\pysteps
+    $ mkdir C:\Users\your_username\pysteps
 
-The next step is to find the location of the library's pystepsrc file is
-actually used.
+The next step is to find the location of the library's default pystepsrc file.
 When we import pysteps in a python interpreter, the configuration file loaded
 is shown::
 
     import pysteps
     "Pysteps configuration file found at: C:\path\to\pysteps\library\pystepsrc"
 
-Then we copy the library's default rc file to that directory::
+Then we copy the library's default configuration file to that directory::
 
-    $ cp C:\path\to\pysteps\library\pystepsrc %USERPROFILE%\pysteps\pystepsrc
+    $ copy C:\path\to\pysteps\library\pystepsrc %USERPROFILE%\pysteps\pystepsrc
 
 Edit the file with the text editor of your preference and change the default
 configurations with your preferences.

pysteps/datasets.py

@@ -258,7 +258,6 @@ def delay(_counter):
             os.makedirs(sub_dir)
 
         # Generate files URL from https://mtarchive.geol.iastate.edu
-
         dest_file_name = datetime.strftime(
             current_date, "PrecipRate_00.00_%Y%m%d-%H%M%S.grib2"
         )
@@ -271,25 +270,23 @@ def delay(_counter):
 
         file_url = archive_url + datetime.strftime(current_date, rel_url_fmt)
 
-        tmp_file = NamedTemporaryFile()
         try:
             print(f"Downloading {file_url} ", end="")
-            request.urlretrieve(
-                file_url, tmp_file.name,
-            )
+            tmp_file_name, _ = request.urlretrieve(file_url)
             print("DONE")
-        except HTTPError as err:
-            print(err)
 
-        dest_file_path = os.path.join(sub_dir, dest_file_name)
+            dest_file_path = os.path.join(sub_dir, dest_file_name)
 
-        # Uncompress the data
-        with gzip.open(tmp_file.name, "rb") as f_in:
-            with open(dest_file_path, "wb") as f_out:
-                shutil.copyfileobj(f_in, f_out)
+            # Uncompress the data
+            with gzip.open(tmp_file_name, "rb") as f_in:
+                with open(dest_file_path, "wb") as f_out:
+                    shutil.copyfileobj(f_in, f_out)
 
-        current_date = current_date + timedelta(seconds=60 * 2)
-        counter += 1
+            current_date = current_date + timedelta(seconds=60 * 2)
+            counter += 1
+
+        except HTTPError as err:
+            print(err)
 
 
 def download_pysteps_data(dir_path, force=True):
@@ -308,7 +305,6 @@ def download_pysteps_data(dir_path, force=True):
         override existing files.
 
     """
-    tmp_file = NamedTemporaryFile()
 
     # Check if directory exists but is not empty
     if os.path.exists(dir_path) and os.path.isdir(dir_path):
@@ -324,17 +320,15 @@ def download_pysteps_data(dir_path, force=True):
     # The http response from github can either contain Content-Length (size of the file)
     # or use chunked Transfer-Encoding.
     # If Transfer-Encoding is chunked, then the Content-Length is not available since
-    # the content is dynamically generated and we can't know the length a pr_iori easily.
+    # the content is dynamically generated and we can't know the length a priori easily.
     pbar = ShowProgress()
     print("Downloading pysteps-data from github.")
-    request.urlretrieve(
-        "https://github.com/pySTEPS/pysteps-data/archive/master.zip",
-        tmp_file.name,
-        pbar,
+    tmp_file_name, _ = request.urlretrieve(
+        "https://github.com/pySTEPS/pysteps-data/archive/master.zip", reporthook=pbar,
     )
     pbar.end(message="Download complete\n")
 
-    with ZipFile(tmp_file.name, "r") as zip_obj:
+    with ZipFile(tmp_file_name, "r") as zip_obj:
         tmp_dir = TemporaryDirectory()
 
         # Extract all the contents of zip file in the temp directory