Bug OR potentially documentation needed

[lwasser]

I'm trying to better understand the hatch environments that we have setup.
When i run the format command i see a conflict with some arguments that i think are passed to ruff

format = "ruff format {args}"

➜ hatch run style:format
Warning: The following rules may cause conflicts when used with the formatter: COM812, ISC001. To avoid unexpected behavior, we recommend disabling these rules, either by removing them from the select or extend-select configuration, or adding them to the ignore configuration.
3 files left unchanged

Should we add these to the default ruff ignore items so the warning doesn't get raised?

[Midnighter]

Both of those are sensible rules to have, in my opinion.

• https://docs.astral.sh/ruff/rules/missing-trailing-comma/
• https://docs.astral.sh/ruff/rules/single-line-implicit-string-concatenation/

Please take a look at this comment astral-sh/ruff#8741 (comment). To summarize, ruff format does not take into account configured rules. Only ruff check does. Here the formatter warns us that it may produce output that conflicts with those rules.

So in a workflow, ruff format should always be followed by ruff check --fix. I do not know how to disable the warning, but I vote for keeping the rules.

[sneakers-the-rat]

this is not a comment that is making a recommendation for or against, i just want to say yoloing ruff enable=["ALL"] is such a bold move

[Midnighter]

My thought is, disable what you don't like ;)