Skip to content

Commit fd0a482

Browse files
MAINT: Update upload-artifact and download-artifact actions from v3 to v4 (#2352)
This is a general fix which covers #2344, #2345 and #2350, including some incompatible changes as detailed in #2344. The key point is that both actions have to be updated at the same time to avoid conflicts. Additionally, artifacts of the same name are not supported anymore, thus I decided to go the recommended route from https://github.com/actions/upload-artifact?tab=readme-ov-file#not-uploading-to-the-same-artifact to include the matrix parameters inside the artifact names.
1 parent 908797f commit fd0a482

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

.github/workflows/github-ci.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,9 @@ jobs:
128128
- name: Rename coverage data file
129129
run: mv .coverage ".coverage.$RANDOM"
130130
- name: Upload coverage data
131-
uses: actions/upload-artifact@v3
131+
uses: actions/upload-artifact@v4
132132
with:
133-
name: coverage-data
133+
name: coverage-data.${{ matrix.python-version }}-${{ matrix.use-crypto-lib }}
134134
path: .coverage.*
135135
if-no-files-found: ignore
136136

@@ -201,9 +201,10 @@ jobs:
201201

202202
- run: python -m pip install --upgrade coverage[toml]
203203

204-
- uses: actions/download-artifact@v3
204+
- uses: actions/download-artifact@v4
205205
with:
206-
name: coverage-data
206+
pattern: coverage-data*
207+
merge-multiple: true
207208

208209
- name: Check Number of Downloaded Files
209210
run: |

0 commit comments

Comments
 (0)