ENH: Automatically preserve links in added pages

Author: larsga

pypdf/_writer.py

@@ -94,10 +94,12 @@
     DecodedStreamObject,
     Destination,
     DictionaryObject,
+    DirectReferenceLink,
     EmbeddedFile,
     Fit,
     FloatObject,
     IndirectObject,
+    NamedReferenceLink,
     NameObject,
     NullObject,
     NumberObject,

pypdf/generic/_link.py

@@ -25,8 +25,8 @@
 # POSSIBILITY OF SUCH DAMAGE.
 
 
-# This module contains code used by _writer.py to track links in pages
-# being added to the writer until the links can be resolved.
+# This module contains classes used by _writer.py to track links in
+# pages being added to the writer until the links can be resolved.
 
 from typing import TYPE_CHECKING, List, Optional, Tuple, Union, cast
 

tests/test_merger.py

@@ -505,11 +505,11 @@ def test_named_ref_to_page_that_is_gone(pdf_file_path):
     source = PdfReader(BytesIO(get_data_from_url(name="named-reference.pdf")))
     buf = BytesIO()
     tmp = PdfWriter()
-    tmp.add_page(source.pages[2])  # we add only the page with the reference
+    tmp.add_page(source.pages[2]) # we add only the page with the reference
     tmp.write(buf)
 
     source = PdfReader(buf)
 
     writer = PdfWriter()
-    writer.add_page(source.pages[0])  # now references to non-existent page
-    writer.write(pdf_file_path)  # don't crash
+    writer.add_page(source.pages[0]) # now references to non-existent page
+    writer.write(pdf_file_path) # don't crash