DEV: Remove ignore Ruff rule B028 (#3214)

B028: No explicit "stacklevel" keyword argument found.

---------

Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>

Author: j-t-1

pypdf/_utils.py

@@ -466,6 +466,7 @@ def rename_kwargs(
                     f"{old_term} is deprecated as an argument. Use {new_term} instead"
                 ),
                 category=DeprecationWarning,
+                stacklevel=3,
             )
 
 

pyproject.toml

@@ -142,7 +142,6 @@ ignore = [
     "ARG001",  # Unused function argument
     "ARG002",  # Unused method argument
     "ARG004",  # Unused static method argument
-    "B028",    # No explicit `stacklevel` keyword argument found
     "B904",    # Within an `except` clause, raise exceptions with
     "B905",    # `zip()` without an explicit `strict=` parameter
     "BLE001",  # Do not catch blind exception: `Exception`

tests/test_utils.py

@@ -1,5 +1,7 @@
 """Test the pypdf._utils module."""
 import io
+import subprocess
+import sys
 from pathlib import Path
 
 import pytest
@@ -276,6 +278,41 @@ def foo(old_param: int = 1, baz: int = 2, new_param: int = 1) -> None:
         foo(old_param=12)
 
 
+def test_rename_kwargs__stacklevel(tmp_path: Path) -> None:
+    script = tmp_path / "script.py"
+    script.write_text("""
+import functools
+import warnings
+
+from pypdf._utils import rename_kwargs
+
+def deprecation(**aliases: str):
+    def decoration(func):
+        @functools.wraps(func)
+        def wrapper(*args, **kwargs):
+            rename_kwargs(func.__name__, kwargs, aliases, fail=False)
+            return func(*args, **kwargs)
+
+        return wrapper
+
+    return decoration
+
+@deprecation(old_param="new_param")
+def foo(old_param: int = 1, baz: int = 2, new_param: int = 1) -> None:
+    pass
+
+warnings.simplefilter("always")
+foo(old_param=12)
+    """)
+
+    result = subprocess.run([sys.executable, script], capture_output=True, text=True)  # noqa: S603
+    assert result.returncode == 0
+    assert result.stderr == (
+        f"{script}:23: DeprecationWarning: old_param is deprecated as an argument. "
+        f"Use new_param instead\n  foo(old_param=12)\n"
+    )
+
+
 @pytest.mark.parametrize(
     ("input_int", "expected_output"),
     [