Skip to content

Commit 7c9b5ff

Browse files
jrivardjrivard
committed
checkstyle final catch parameters
1 parent 1c1e8cd commit 7c9b5ff

File tree

304 files changed

+1180
-1173
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

304 files changed

+1180
-1173
lines changed

‎build/checkstyle.xml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,12 +269,16 @@
269269
<module name="FallThrough"/>
270270
<module name="EqualsHashCode"/>
271271
<module name="ArrayTrailingCommaCheck"/>
272-
<module name="FinalLocalVariable"/>
272+
<module name="FinalLocalVariable">
273+
<property name="validateEnhancedForLoopVariable" value="true"/>
274+
</module>
273275
<module name="MissingSwitchDefault"/>
274276
<module name="ModifiedControlVariable"/>
275277
<module name="MultipleVariableDeclarations"/>
276278
<module name="OneStatementPerLine"/>
277-
<module name="FinalParameters"/>
279+
<module name="FinalParameters">
280+
<property name="tokens" value="METHOD_DEF,CTOR_DEF,LITERAL_CATCH"/>
281+
</module>
278282
<module name="ParameterAssignment"/>
279283
<module name="SimplifyBooleanReturn"/>
280284
<module name="StringLiteralEquality"/>

‎data-service/src/main/java/password/pwm/receiver/FtpDataIngestor.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ void readData( final Storage storage )
7474
{
7575
readFile( ftpClient, fileName, storage );
7676
}
77-
catch ( Exception e )
77+
catch ( final Exception e )
7878
{
7979
app.getStatus().setLastFtpIngest( Instant.now() );
8080
final String msg = "error while reading ftp file '" + fileName + "': " + e.getMessage();
@@ -93,7 +93,7 @@ void readData( final Storage storage )
9393
app.getStatus().setLastFtpIngest( Instant.now() );
9494
app.getStatus().setLastFtpFilesRead( files.size() );
9595
}
96-
catch ( Exception e )
96+
catch ( final Exception e )
9797
{
9898
app.getStatus().setLastFtpIngest( Instant.now() );
9999
app.getStatus().setLastFtpStatus( "error during ftp scan: " + e.getMessage() );
@@ -130,7 +130,7 @@ private void readZippedByteStream( final InputStream inputStream, final String f
130130
storage.store( bean );
131131
}
132132
}
133-
catch ( Exception e )
133+
catch ( final Exception e )
134134
{
135135
final String msg = "error reading ftp file '" + fileName + "', error: " + e.getMessage();
136136
LOGGER.info( msg );

‎data-service/src/main/java/password/pwm/receiver/PwmReceiverApp.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public PwmReceiverApp( )
5353
{
5454
settings = Settings.readFromFile( propsFile );
5555
}
56-
catch ( IOException e )
56+
catch ( final IOException e )
5757
{
5858
final String errorMsg = "can't read configuration: " + JavaHelper.readHostileExceptionMessage( e );
5959
status.setErrorState( errorMsg );
@@ -65,7 +65,7 @@ public PwmReceiverApp( )
6565
{
6666
storage = new Storage( settings );
6767
}
68-
catch ( Exception e )
68+
catch ( final Exception e )
6969
{
7070
final String errorMsg = "can't start storage system: " + JavaHelper.readHostileExceptionMessage( e );
7171
status.setErrorState( errorMsg );

‎data-service/src/main/java/password/pwm/receiver/Storage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ private void doNext( )
173173
}
174174
nextValue = string;
175175
}
176-
catch ( Exception e )
176+
catch ( final Exception e )
177177
{
178178
e.printStackTrace();
179179
throw e;

‎data-service/src/main/java/password/pwm/receiver/TelemetryRestReceiver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,11 @@ protected void doPost( final HttpServletRequest req, final HttpServletResponse r
5858
stoage.store( telemetryPublishBean );
5959
resp.getWriter().print( RestResultBean.forSuccessMessage( null, null, null, Message.Success_Unknown ).toJson() );
6060
}
61-
catch ( PwmUnrecoverableException e )
61+
catch ( final PwmUnrecoverableException e )
6262
{
6363
resp.getWriter().print( RestResultBean.fromError( e.getErrorInformation() ).toJson() );
6464
}
65-
catch ( Exception e )
65+
catch ( final Exception e )
6666
{
6767
final RestResultBean restResultBean = RestResultBean.fromError( new ErrorInformation( PwmError.ERROR_INTERNAL, e.getMessage() ) );
6868
resp.getWriter().print( restResultBean.toJson() );

‎onejar/src/main/java/password/pwm/onejar/ArgumentParser.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public OnejarConfig parseArguments( final String[] args )
5858
{
5959
commandLine = new DefaultParser().parse( Argument.asOptions(), args );
6060
}
61-
catch ( ParseException e )
61+
catch ( final ParseException e )
6262
{
6363
throw new ArgumentParserException( "unable to parse command line: " + e.getMessage() );
6464
}
@@ -100,7 +100,7 @@ else if ( commandLine.hasOption( Argument.help.name() ) )
100100
{
101101
onejarConfig = makeTomcatConfig( argumentMap );
102102
}
103-
catch ( IOException e )
103+
catch ( final IOException e )
104104
{
105105
throw new ArgumentParserException( "error while reading input: " + e.getMessage() );
106106
}
@@ -118,7 +118,7 @@ private Map<Argument, String> mapFromProperties( final String filename ) throws
118118
{
119119
props.load( is );
120120
}
121-
catch ( IOException e )
121+
catch ( final IOException e )
122122
{
123123
throw new ArgumentParserException( "unable to read properties input file: " + e.getMessage() );
124124
}
@@ -204,7 +204,7 @@ private OnejarConfig makeTomcatConfig( final Map<Argument, String> argumentMap )
204204
port = Integer.parseInt( argumentMap.get( Argument.port ) );
205205
onejarConfig.port( port );
206206
}
207-
catch ( NumberFormatException e )
207+
catch ( final NumberFormatException e )
208208
{
209209
final String msg = Argument.port.name() + " argument must be numeric";
210210
System.out.println( msg );
@@ -228,7 +228,7 @@ private OnejarConfig makeTomcatConfig( final Map<Argument, String> argumentMap )
228228
final ServerSocket socket = new ServerSocket( port, 100, InetAddress.getByName( localAddress ) );
229229
socket.close();
230230
}
231-
catch ( Exception e )
231+
catch ( final Exception e )
232232
{
233233
throw new ArgumentParserException( "port or address conflict: " + e.getMessage() );
234234
}

‎onejar/src/main/java/password/pwm/onejar/OnejarMain.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public static void main( final String[] args )
5252
{
5353
onejarConfig = argumentParser.parseArguments( args );
5454
}
55-
catch ( ArgumentParserException | OnejarException e )
55+
catch ( final ArgumentParserException | OnejarException e )
5656
{
5757
output( "error parsing command line: " + e.getMessage() );
5858
}
@@ -91,7 +91,7 @@ private void execCommand( final OnejarConfig onejarConfig )
9191

9292
mainMethod.invoke( null, ( Object ) arguments );
9393
}
94-
catch ( Exception e )
94+
catch ( final Exception e )
9595
{
9696
e.printStackTrace( );
9797
}
@@ -111,7 +111,7 @@ void deployWebApp( final OnejarConfig onejarConfig )
111111
runner.startTomcat( onejarConfig );
112112

113113
}
114-
catch ( OnejarException | ServletException | IOException e )
114+
catch ( final OnejarException | ServletException | IOException e )
115115
{
116116
out( "error starting tomcat: " + e.getMessage() );
117117
}

‎onejar/src/main/java/password/pwm/onejar/TomcatOnejarRunner.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ void startTomcat( final OnejarConfig onejarConfig )
7070
tlsProperties = this.executeOnejarHelper( onejarConfig );
7171
out( "keystore generated" );
7272
}
73-
catch ( Exception e )
73+
catch ( final Exception e )
7474
{
7575
throw new OnejarException( "error generating keystore: " + e.getMessage() );
7676
}
@@ -113,7 +113,7 @@ void startTomcat( final OnejarConfig onejarConfig )
113113
tomcat.start();
114114
out( "tomcat started in " + Duration.between( Instant.now(), startTime ).toString() );
115115
}
116-
catch ( Exception e )
116+
catch ( final Exception e )
117117
{
118118
throw new OnejarException( "unable to start tomcat: " + e.getMessage() );
119119
}
@@ -199,7 +199,7 @@ static String getVersion( ) throws OnejarException
199199
return attr.getValue( "Implementation-Version-Display" )
200200
+ " [" + ServerInfo.getServerInfo() + "]";
201201
}
202-
catch ( IOException e )
202+
catch ( final IOException e )
203203
{
204204
throw new OnejarException( "error reading internal version info: " + e.getMessage() );
205205
}

‎pwm-cr/src/main/java/password/pwm/cr/ChaiXmlResponseSetSerializer.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ public Map<Type, StoredResponseSet> read( final Reader input )
142142
{
143143
timestamp = CrUtils.parseDateString( timeStr );
144144
}
145-
catch ( ParseException e )
145+
catch ( final ParseException e )
146146
{
147147
throw new IllegalArgumentException( "unexpected error attempting to parse timestamp: " + e.getMessage() );
148148
}
@@ -173,14 +173,14 @@ public Map<Type, StoredResponseSet> read( final Reader input )
173173
break;
174174

175175
default:
176-
throw new IllegalStateException( "unknown response type '" + type + "'" );
176+
throw new IllegalStateException( "unknown response type '" + type + '\'' );
177177

178178
}
179179
}
180180
}
181181
}
182182
}
183-
catch ( JDOMException | IOException | NullPointerException e )
183+
catch ( final JDOMException | IOException | NullPointerException e )
184184
{
185185
throw new IllegalArgumentException( "error parsing stored response record: " + e.getMessage() );
186186
}
@@ -228,7 +228,7 @@ private static String elementNameForType( final Type type )
228228
return XML_NODE_HELPDESK_RESPONSE;
229229

230230
default:
231-
throw new IllegalArgumentException( "unknown type '" + type + "'" );
231+
throw new IllegalArgumentException( "unknown type '" + type + '\'' );
232232
}
233233
}
234234

@@ -279,7 +279,7 @@ private static StoredResponseItem parseAnswerElement( final Element element )
279279
{
280280
saltCount = Integer.parseInt( hashCount );
281281
}
282-
catch ( NumberFormatException e )
282+
catch ( final NumberFormatException e )
283283
{
284284
/* noop */
285285
}
@@ -306,7 +306,7 @@ private static String makeId(
306306
final byte[] hashedBytes = md.digest( questionText.getBytes( StandardCharsets.UTF_8 ) );
307307
return net.iharder.Base64.encodeBytes( hashedBytes, Base64.URL_SAFE );
308308
}
309-
catch ( NoSuchAlgorithmException | IOException e )
309+
catch ( final NoSuchAlgorithmException | IOException e )
310310
{
311311
throw new IllegalStateException( "unable to load SHA1 message digest algorithm: " + e.getMessage() );
312312
}

‎pwm-cr/src/main/java/password/pwm/cr/CrUtils.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import java.time.Instant;
2727
import java.util.TimeZone;
2828

29+
@SuppressWarnings( "checkstyle:MultipleStringLiterals" )
2930
public class CrUtils
3031
{
3132
static final String DATE_FORMAT = "yyyy-MM-dd HH:mm:ss Z";

0 commit comments

Comments
 (0)