Skip to content

Examples do not build #54

@patrick-nicodemus

Description

@patrick-nicodemus

I get the following errors when trying to build the examples.

File "lib/utils/toplevel_eval.ml", line 32, characters 4-18:
32 |     Printf.kprintf (fun s -> ignore (Sys.command s)) fmt
         ^^^^^^^^^^^^^^
Error (alert deprecated): Stdlib.Printf.kprintf
Use Printf.ksprintf instead.
File "examples/chipseq.ml", line 5, characters 5-19:
5 | open Bistro_bioinfo
         ^^^^^^^^^^^^^^
Error: Unbound module Bistro_bioinfo
File "examples/zhou2018.ml", line 6, characters 5-16:
6 | open Core_kernel
         ^^^^^^^^^^^
Error (alert deprecated): module Core_kernel
[since 2021-05] Use [Core] -- [Core_kernel] was renamed as [Core]

File "examples/zhou2018.ml", lines 18-19, characters 4-26:
18 | ....Bistro_unix.wget "https://ndownloader.figshare.com/files/9473962"
19 |     |> Bistro_unix.tar_xfj
Error: This expression has type
         (#regular_file_t as 'a) file = 'a path workflow
       but an expression was expected of type
         'b directory =
           < contents : 'b; file_kind : [ `directory ] > path workflow
       Type #regular_file_t as 'a = < file_kind : [ `regular ]; .. >
       is not compatible with type
         < contents : 'b; file_kind : [ `directory ] >
       These two variant types have no intersection
File "examples/rnaseq.ml", line 8, characters 5-19:
8 | open Bistro_bioinfo
         ^^^^^^^^^^^^^^
Error: Unbound module Bistro_bioinfo

I think that upgrading from (lang dune 1.11) to (lang dune 2.0) will automatically build the examples by default with dune build which will make it easier to catch these breakages.

(Honestly I think the behavior of dune build on versions before 2.0 is pretty unintuitive and I wasted a lot of time trying to understand why it wasn't working as I expected.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions