Skip to content

Commit 94f4f0d

Browse files
author
Daniel Browne
committed
Enable 'test_case_accessibility' SwiftLint rule
1 parent 1053113 commit 94f4f0d

15 files changed

+49
-48
lines changed

‎.swiftlint.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ opt_in_rules:
1212
- modifier_order
1313
- prefer_self_type_over_type_of_self
1414
- sorted_imports
15+
- test_case_accessibility
1516
- vertical_whitespace_between_cases
1617
- vertical_whitespace_closing_braces
1718

‎Tests/Integration/AuthenticationTests.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import XCTest
33
@testable import PusherSwift
44

55
class AuthenticationTests: XCTestCase {
6-
class DummyDelegate: PusherDelegate {
6+
private class DummyDelegate: PusherDelegate {
77
var ex: XCTestExpectation?
88
var testingChannelName: String?
99

@@ -16,8 +16,8 @@ class AuthenticationTests: XCTestCase {
1616
}
1717
}
1818

19-
var pusher: Pusher!
20-
var socket: MockWebSocket!
19+
private var pusher: Pusher!
20+
private var socket: MockWebSocket!
2121

2222
override func setUp() {
2323
super.setUp()

‎Tests/Integration/PusherClientInitializationTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import XCTest
55
let VERSION = "9.2.0"
66

77
class ClientInitializationTests: XCTestCase {
8-
var key: String!
9-
var pusher: Pusher!
8+
private var key: String!
9+
private var pusher: Pusher!
1010

1111
override func setUp() {
1212
super.setUp()

‎Tests/Integration/PusherIncomingEventHandlingTests.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ import XCTest
55
// swiftlint:disable unused_closure_parameter
66

77
class HandlingIncomingEventsTests: XCTestCase {
8-
var key: String!
9-
var pusher: Pusher!
10-
var socket: MockWebSocket!
8+
private var key: String!
9+
private var pusher: Pusher!
10+
private var socket: MockWebSocket!
1111

1212
override func setUp() {
1313
super.setUp()

‎Tests/Integration/PusherTopLevelAPITests.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import XCTest
66

77
class PusherTopLevelApiTests: XCTestCase {
88

9-
class ConnectionStateDelegate: PusherDelegate {
9+
private class ConnectionStateDelegate: PusherDelegate {
1010
var callbacks: [ConnectionState: [() -> Void]] = [:]
1111

1212
func registerCallback(connectionState: ConnectionState, callback: @escaping () -> Void) {
@@ -26,7 +26,7 @@ class PusherTopLevelApiTests: XCTestCase {
2626
}
2727
}
2828

29-
class DummyDelegate: PusherDelegate {
29+
private class DummyDelegate: PusherDelegate {
3030
var ex: XCTestExpectation?
3131
var testingChannelName: String?
3232
var connectionStubber = StubberForMocks()
@@ -49,9 +49,9 @@ class PusherTopLevelApiTests: XCTestCase {
4949
}
5050
}
5151

52-
var key: String!
53-
var pusher: Pusher!
54-
var socket: MockWebSocket!
52+
private var key: String!
53+
private var pusher: Pusher!
54+
private var socket: MockWebSocket!
5555

5656
override func setUp() {
5757
super.setUp()

‎Tests/Unit/Helpers/PusherEventFactory+DecryptionTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import XCTest
33

44
class PusherEventFactoryDecryptionTests: XCTestCase {
55

6-
var eventFactory: PusherConcreteEventFactory!
6+
private var eventFactory: PusherConcreteEventFactory!
77

88
override func setUp() {
99
eventFactory = PusherConcreteEventFactory()

‎Tests/Unit/Helpers/PusherEventFactoryTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import XCTest
44

55
class PusherEventFactoryTests: XCTestCase {
66

7-
var eventFactory: PusherConcreteEventFactory!
7+
private var eventFactory: PusherConcreteEventFactory!
88

99
override func setUp() {
1010
eventFactory = PusherConcreteEventFactory()

‎Tests/Unit/Models/ClientEventTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import XCTest
33
@testable import PusherSwift
44

55
class ClientEventTests: XCTestCase {
6-
var connection: MockPusherConnection!
7-
var socket: MockWebSocket!
6+
private var connection: MockPusherConnection!
7+
private var socket: MockWebSocket!
88

99
override func setUp() {
1010
super.setUp()

‎Tests/Unit/Models/PresenceChannelTests.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import XCTest
33
@testable import PusherSwift
44

55
class PusherPresenceChannelTests: XCTestCase {
6-
var pusher: Pusher!
7-
var socket: MockWebSocket!
8-
var options: PusherClientOptions!
9-
var stubber: StubberForMocks!
6+
private var pusher: Pusher!
7+
private var socket: MockWebSocket!
8+
private var options: PusherClientOptions!
9+
private var stubber: StubberForMocks!
1010

1111
override func setUp() {
1212
super.setUp()

‎Tests/Unit/Models/PrivateEncryptedChannelTests.swift

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class PrivateEncryptedChannelTests: XCTestCase {
1313
private let incorrectSharedSecretAuth = PusherAuth(auth: "636a81ba7e7b15725c00:3ee04892514e8a669dc5d30267221f16727596688894712cad305986e6fc0f3c", sharedSecret: "iBvNoPVYwByqSfg6anjPpEQ2j051b3rt1Vmnb+z5do0=")
1414
private lazy var incorrectSharedSecretAuthData = "{\"auth\":\"\(incorrectSharedSecretAuth.auth)\",\"shared_secret\":\"\(incorrectSharedSecretAuth.sharedSecret!)\"}"
1515

16-
func configurePusherWithAuthMethod(authMethod: AuthMethod? = nil) -> (Pusher, MockWebSocket) {
16+
private func configurePusherWithAuthMethod(authMethod: AuthMethod? = nil) -> (Pusher, MockWebSocket) {
1717
super.setUp()
1818

1919
let authMethod = authMethod ?? AuthMethod.endpoint(authEndpoint: authEndpointURL)
@@ -202,7 +202,7 @@ class PrivateEncryptedChannelTests: XCTestCase {
202202
waitForExpectations(timeout: 1)
203203
}
204204

205-
func authorizerResponseSequence(_ authSequence: [PusherAuth]) {
205+
private func authorizerResponseSequence(_ authSequence: [PusherAuth]) {
206206
let (pusher, socket) = configurePusherWithAuthMethod(authMethod: AuthMethod.authorizer(authorizer: TestAuthorizer(authSequence)))
207207
pusher.connect()
208208

@@ -333,7 +333,7 @@ class PrivateEncryptedChannelTests: XCTestCase {
333333
}
334334

335335
// PusherDelegate that handles the expectation that a subscription event has occurred
336-
class DummySubscriptionDelegate: PusherDelegate {
336+
private class DummySubscriptionDelegate: PusherDelegate {
337337
var expectation: XCTestExpectation?
338338
var channelName: String?
339339

@@ -345,7 +345,7 @@ class PrivateEncryptedChannelTests: XCTestCase {
345345
}
346346
}
347347

348-
class TestAuthorizer: Authorizer {
348+
private class TestAuthorizer: Authorizer {
349349
var authResponseSequence: [PusherAuth]
350350
public init(_ authResponseSequence: [PusherAuth]) {
351351
self.authResponseSequence = authResponseSequence
@@ -355,7 +355,7 @@ class PrivateEncryptedChannelTests: XCTestCase {
355355
}
356356
}
357357

358-
class TestAuthRequestBuilder: AuthRequestBuilderProtocol {
358+
private class TestAuthRequestBuilder: AuthRequestBuilderProtocol {
359359
func requestFor(socketID: String, channelName: String) -> URLRequest? {
360360
var request = URLRequest(url: URL(string: "http://localhost:3030")!)
361361
request.httpMethod = "POST"
@@ -364,7 +364,7 @@ class PrivateEncryptedChannelTests: XCTestCase {
364364
}
365365
}
366366

367-
class DummyErrorDelegate: PusherDelegate {
367+
private class DummyErrorDelegate: PusherDelegate {
368368
var expectation: XCTestExpectation?
369369
var channelName: String?
370370

@@ -376,7 +376,7 @@ class PrivateEncryptedChannelTests: XCTestCase {
376376
}
377377

378378
// utility method to mock an authorizer response with the jsonData provided
379-
func mockAuthResponse(jsonData: String, pusher: Pusher) {
379+
private func mockAuthResponse(jsonData: String, pusher: Pusher) {
380380
let urlResponse = HTTPURLResponse(
381381
url: URL(string: "\(authEndpointURL)?channel_name=\(channelName)&socket_id=45481.3166671")!,
382382
statusCode: 200,

0 commit comments

Comments
 (0)