Remove redunant 'public' keywords from Tests

Author: danielrbrowne

Tests/Extensions/String+Extensions.swift

@@ -2,7 +2,7 @@ import XCTest
 
 extension String {
 
-    public func removing(_ set: CharacterSet) -> String {
+    func removing(_ set: CharacterSet) -> String {
         var newString = self
         newString.removeAll { char -> Bool in
             guard let scalar = char.unicodeScalars.first else { return false }
@@ -11,11 +11,11 @@ extension String {
         return newString
     }
 
-    public var escaped: String {
+    var escaped: String {
         return self.debugDescription
     }
 
-    public func toJsonData(validate: Bool = true, file: StaticString = #file, line: UInt = #line) -> Data {
+    func toJsonData(validate: Bool = true, file: StaticString = #file, line: UInt = #line) -> Data {
         do {
             let data = try self.toData()
             if validate {
@@ -29,7 +29,7 @@ extension String {
         return Data()
     }
 
-    public func toJsonDict(file: StaticString = #file, line: UInt = #line) -> [String: Any] {
+    func toJsonDict(file: StaticString = #file, line: UInt = #line) -> [String: Any] {
         do {
             let json = try toJsonAny()
 

Tests/Extensions/XCTest+Assertions.swift

@@ -8,7 +8,7 @@ private func executeAndAssignEquatableResult<T>(_ expression: @autoclosure () th
     to = try expression()
 }
 
-public func XCTAssertNotNil<T>(_ expression: @autoclosure () throws -> T?, _ message: String = "", file: StaticString = #file, line: UInt = #line, also validateResult: (T) -> Void) {
+func XCTAssertNotNil<T>(_ expression: @autoclosure () throws -> T?, _ message: String = "", file: StaticString = #file, line: UInt = #line, also validateResult: (T) -> Void) {
 
     var result: T?
 

Tests/Helpers/Mocks.swift

@@ -217,7 +217,7 @@ open class MockWebSocket: NWWebSocket {
     }
 }
 
-public func stringContainsElements(_ str: String, elements: [String]) -> Bool {
+func stringContainsElements(_ str: String, elements: [String]) -> Bool {
     var allElementsPresent = true
     for element in elements {
         if str.range(of: element) == nil {
@@ -279,27 +279,27 @@ open class StubberForMocks {
 }
 
 open class FunctionCall {
-    public let name: String
-    public let args: [Any]?
+    let name: String
+    let args: [Any]?
 
     init(name: String, args: [Any]?) {
         self.name = name
         self.args = args
     }
 }
 
-public typealias Response = (data: Data?, urlResponse: URLResponse?, error: NSError?)
+typealias Response = (data: Data?, urlResponse: URLResponse?, error: NSError?)
 
-public class MockSession: URLSession {
-    public static var mockResponses: [String: Response] = [:]
+class MockSession: URLSession {
+    static var mockResponses: [String: Response] = [:]
     // swiftlint:disable:next large_tuple
-    public static var mockResponse: (data: Data?, urlResponse: URLResponse?, error: NSError?) = (data: nil, urlResponse: nil, error: nil)
+    static var mockResponse: (data: Data?, urlResponse: URLResponse?, error: NSError?) = (data: nil, urlResponse: nil, error: nil)
 
-    override public class var shared: URLSession {
+    override class var shared: URLSession {
         return MockSession()
     }
 
-    override public func dataTask(with: URLRequest, completionHandler: @escaping (Data?, URLResponse?, Error?) -> Void) -> URLSessionDataTask {
+    override func dataTask(with: URLRequest, completionHandler: @escaping (Data?, URLResponse?, Error?) -> Void) -> URLSessionDataTask {
         var response: Response
         let mockedMethodAndUrlString = "\(with.httpMethod!)||\((with.url?.absoluteString)!)"
 
@@ -311,22 +311,22 @@ public class MockSession: URLSession {
         return MockTask(response: response, completionHandler: completionHandler)
     }
 
-    public class func addMockResponse(for url: URL, httpMethod: String, data: Data?, urlResponse: URLResponse?, error: NSError?) {
+    class func addMockResponse(for url: URL, httpMethod: String, data: Data?, urlResponse: URLResponse?, error: NSError?) {
         let response = (data: data, urlResponse: urlResponse, error: error)
         let mockedResponseString = "\(httpMethod)||\(url.absoluteString)"
         mockResponses[mockedResponseString] = response
     }
 
-    public class MockTask: URLSessionDataTask {
-        public var mockResponse: Response
-        public let completionHandler: ((Data?, URLResponse?, NSError?) -> Void)?
+    class MockTask: URLSessionDataTask {
+        var mockResponse: Response
+        let completionHandler: ((Data?, URLResponse?, NSError?) -> Void)?
 
-        public init(response: Response, completionHandler: ((Data?, URLResponse?, NSError?) -> Void)?) {
+        init(response: Response, completionHandler: ((Data?, URLResponse?, NSError?) -> Void)?) {
             self.mockResponse = response
             self.completionHandler = completionHandler
         }
 
-        override public func resume() {
+        override func resume() {
             DispatchQueue.global(qos: .default).async {
                 self.completionHandler!(self.mockResponse.data, self.mockResponse.urlResponse, self.mockResponse.error)
             }

Tests/Unit/Models/PrivateEncryptedChannelTests.swift

@@ -347,7 +347,7 @@ class PrivateEncryptedChannelTests: XCTestCase {
 
     private class TestAuthorizer: Authorizer {
         var authResponseSequence: [PusherAuth]
-        public init(_ authResponseSequence: [PusherAuth]) {
+        init(_ authResponseSequence: [PusherAuth]) {
             self.authResponseSequence = authResponseSequence
         }
         func fetchAuthValue(socketID: String, channelName: String, completionHandler: @escaping (PusherAuth?) -> Void) {

Tests/Unit/Protocols/PusherConnectionDelegateTests.swift

@@ -4,7 +4,7 @@ import XCTest
 
 class PusherConnectionDelegateTests: XCTestCase {
     private class DummyDelegate: PusherDelegate {
-        public let stubber = StubberForMocks()
+        let stubber = StubberForMocks()
         open var socket: MockWebSocket?
         open var ex: XCTestExpectation?
         var testingChannelName: String?