Fix compiler warnings

Author: Tom Kemp

Sources/ObjectiveC.swift

@@ -1,41 +1,41 @@
 import Foundation
 
 @objc public extension Pusher {
-    public func subscribe(channelName: String) -> PusherChannel {
+    func subscribe(channelName: String) -> PusherChannel {
         return self.subscribe(channelName, onMemberAdded: nil, onMemberRemoved: nil)
     }
 
-    public func subscribe(
+    func subscribe(
         channelName: String,
         onMemberAdded: ((PusherPresenceChannelMember) -> ())? = nil,
         onMemberRemoved: ((PusherPresenceChannelMember) -> ())? = nil
     ) -> PusherChannel {
         return self.subscribe(channelName, auth: nil, onMemberAdded: onMemberAdded, onMemberRemoved: onMemberRemoved)
     }
 
-    public func subscribeToPresenceChannel(channelName: String) -> PusherPresenceChannel {
+    func subscribeToPresenceChannel(channelName: String) -> PusherPresenceChannel {
         return self.subscribeToPresenceChannel(channelName: channelName, auth: nil, onMemberAdded: nil, onMemberRemoved: nil)
     }
 
-    public func subscribeToPresenceChannel(
+    func subscribeToPresenceChannel(
         channelName: String,
         onMemberAdded: ((PusherPresenceChannelMember) -> ())? = nil,
         onMemberRemoved: ((PusherPresenceChannelMember) -> ())? = nil
     ) -> PusherPresenceChannel {
         return self.subscribeToPresenceChannel(channelName: channelName, auth: nil, onMemberAdded: onMemberAdded, onMemberRemoved: onMemberRemoved)
     }
 
-    public convenience init(withAppKey key: String, options: PusherClientOptions) {
+    convenience init(withAppKey key: String, options: PusherClientOptions) {
         self.init(key: key, options: options)
     }
 
-    public convenience init(withKey key: String) {
+    convenience init(withKey key: String) {
         self.init(key: key)
     }
 }
 
 @objc public extension PusherConnection {
-    public var OCReconnectAttemptsMax: NSNumber? {
+    var OCReconnectAttemptsMax: NSNumber? {
         get {
             return reconnectAttemptsMax as NSNumber?
         }
@@ -44,7 +44,7 @@ import Foundation
         }
     }
 
-    public var OCMaxReconnectGapInSeconds: NSNumber? {
+    var OCMaxReconnectGapInSeconds: NSNumber? {
         get {
             return maxReconnectGapInSeconds as NSNumber?
         }
@@ -55,7 +55,7 @@ import Foundation
 }
 
 @objc public extension PusherClientOptions {
-    public convenience init(
+    convenience init(
         ocAuthMethod authMethod: OCAuthMethod,
         attemptToReturnJSONObject: Bool = true,
         autoReconnect: Bool = true,
@@ -75,11 +75,11 @@ import Foundation
         )
     }
 
-    public convenience init(authMethod: OCAuthMethod) {
+    convenience init(authMethod: OCAuthMethod) {
         self.init(authMethod: AuthMethod.fromObjc(source: authMethod))
     }
 
-    public func setAuthMethod(authMethod: OCAuthMethod) {
+    func setAuthMethod(authMethod: OCAuthMethod) {
         self.authMethod = AuthMethod.fromObjc(source: authMethod)
     }
 }

Sources/PusherChannel.swift

@@ -28,10 +28,10 @@ public enum PusherChannelType {
 open class PusherChannel: NSObject {
     open var eventHandlers: [String: [EventHandler]] = [:]
     open var subscribed = false
-    open let name: String
+    public let name: String
     open weak var connection: PusherConnection?
     open var unsentEvents = [PusherEvent]()
-    open let type: PusherChannelType
+    public let type: PusherChannelType
     public var auth: PusherAuth?
 
     /**

Sources/PusherConnection.swift

@@ -7,8 +7,8 @@ public typealias PusherEventJSON = [String: AnyObject]
 
 @objcMembers
 @objc open class PusherConnection: NSObject {
-    open let url: String
-    open let key: String
+    public let url: String
+    public let key: String
     open var options: PusherClientOptions
     open var globalChannel: GlobalChannel!
     open var socketId: String?

Sources/PusherSwift.swift

@@ -7,7 +7,7 @@ let CLIENT_NAME = "pusher-websocket-swift"
 
 @objcMembers
 @objc open class Pusher: NSObject {
-    open let connection: PusherConnection
+    public let connection: PusherConnection
     open weak var delegate: PusherDelegate? = nil {
         willSet {
             self.connection.delegate = newValue

Tests/Mocks.swift

@@ -249,8 +249,8 @@ open class StubberForMocks {
 }
 
 open class FunctionCall {
-    open let name: String
-    open let args: [Any]?
+    public let name: String
+    public let args: [Any]?
 
     init(name: String, args: [Any]?) {
         self.name = name

Tests/PusherConnectionDelegateTests.swift

@@ -3,7 +3,7 @@ import XCTest
 
 class PusherConnectionDelegateTests: XCTestCase {
     open class DummyDelegate: PusherDelegate {
-        open let stubber = StubberForMocks()
+        public let stubber = StubberForMocks()
         open var socket: MockWebSocket? = nil
         open var ex: XCTestExpectation? = nil
         var testingChannelName: String? = nil