Enable 'modifier_order' SwiftLint rule

Author: Daniel Browne

.swiftlint.yml

@@ -9,6 +9,7 @@ opt_in_rules:
   - closure_end_indentation
   - closure_spacing
   - explicit_init
+  - modifier_order
   - vertical_whitespace_between_cases
   - vertical_whitespace_closing_braces
 

Sources/ObjC/ObjectiveC.swift

@@ -137,7 +137,7 @@ public extension PusherHost {
     var host: String?
     var cluster: String?
 
-    public override init() {
+    override public init() {
         self.type = 2
     }
 

Tests/Helpers/Mocks.swift

@@ -26,7 +26,7 @@ open class MockWebSocket: NWWebSocket {
         self.eventGivenToCallback = event
     }
 
-    open override func connect() {
+    override open func connect() {
         let connectionEstablishedString = "{\"event\":\"pusher:connection_established\",\"data\":\"{\\\"socket_id\\\":\\\"45481.3166671\\\",\\\"activity_timeout\\\":120}\"}"
         _ = stubber.stub(
             functionName: "connect",
@@ -42,7 +42,7 @@ open class MockWebSocket: NWWebSocket {
         )
     }
 
-    open override func disconnect(closeCode: NWProtocolWebSocket.CloseCode = .protocolCode(.normalClosure)) {
+    override open func disconnect(closeCode: NWProtocolWebSocket.CloseCode = .protocolCode(.normalClosure)) {
         _ = stubber.stub(
             functionName: "disconnect",
             args: nil,
@@ -55,7 +55,7 @@ open class MockWebSocket: NWWebSocket {
     }
 
     // swiftlint:disable:next function_body_length cyclomatic_complexity
-    open override func send(string: String) {
+    override open func send(string: String) {
         if string == "{\"data\":{\"channel\":\"test-channel\"},\"event\":\"pusher:subscribe\"}" || string == "{\"event\":\"pusher:subscribe\",\"data\":{\"channel\":\"test-channel\"}}" {
             _ = stubber.stub(
                 functionName: "writeString",
@@ -235,7 +235,7 @@ open class MockPusherConnection: PusherConnection {
         super.init(key: "key", socket: MockWebSocket(), url: "ws://blah.blah:80", options: options)
     }
 
-    open override func handleEvent(event: PusherEvent) {
+    override open func handleEvent(event: PusherEvent) {
         _ = stubber.stub(
             functionName: "handleEvent",
             args: [event],
@@ -291,9 +291,9 @@ open class FunctionCall {
 public typealias Response = (data: Data?, urlResponse: URLResponse?, error: NSError?)
 
 public class MockSession: URLSession {
-    static public var mockResponses: [String: Response] = [:]
+    public static var mockResponses: [String: Response] = [:]
     // swiftlint:disable:next large_tuple
-    static public var mockResponse: (data: Data?, urlResponse: URLResponse?, error: NSError?) = (data: nil, urlResponse: nil, error: nil)
+    public static var mockResponse: (data: Data?, urlResponse: URLResponse?, error: NSError?) = (data: nil, urlResponse: nil, error: nil)
 
     override public class var shared: URLSession {
         return MockSession()