Merge pull request #111 from pusher/add-register-fail-delegate-func

Add failedToRegisterForPushNotifications func to PusherDelegate.

Author: hamchapman

README.md

@@ -925,13 +925,15 @@ You can also implement some of the `PusherDelegate` functions to get access to e
 
 ```swift
 @objc optional func registeredForPushNotifications(clientId: String)
+@objc optional func failedToRegisterForPushNotifications(response: URLResponse, responseBody: String?)
 @objc optional func subscribedToInterest(name: String)
 @objc optional func unsubscribedFromInterest(name: String)
 ```
 
 Again, the names of the functions largely give away what their purpose is but just for completeness:
 
 - `registeredForPushNotifications` - use this if you want to know when a client has successfully registered with the Pusher Push Notifications service, or if you want access to the `clientId` that is returned upon successful registration
+- `failedToRegisterForPushNotifications` - use this if you want to know when a client has failed to register with the Pusher Push Notifications service
 - `subscribedToInterest` - use this if you want keep track of interests that are successfully subscribed to
 - `unsubscribedFromInterest` - use this if you want keep track of interests that are successfully unsubscribed from
 

Source/NativePusher.swift

@@ -135,6 +135,7 @@
             } else {
                 if data != nil && response != nil {
                     let responseBody = String(data: data!, encoding: .utf8)
+                    self.delegate?.failedToRegisterForPushNotifications?(response: response!, responseBody: responseBody)
                     self.delegate?.debugLog?(message: "Bad HTTP response: \(response!) with body: \(responseBody)")
                 }
             }

Source/PusherDelegate.swift

@@ -10,6 +10,7 @@
     @objc optional func debugLog(message: String)
 
     @objc optional func registeredForPushNotifications(clientId: String)
+    @objc optional func failedToRegisterForPushNotifications(response: URLResponse, responseBody: String?)
     @objc optional func subscribedToInterest(name: String)
     @objc optional func unsubscribedFromInterest(name: String)
 

Tests/NativePusherTests.swift

@@ -34,6 +34,7 @@ class NativePusherTests: XCTestCase {
         public var registerEx: XCTestExpectation? = nil
         public var subscribeEx: XCTestExpectation? = nil
         public var unsubscribeEx: XCTestExpectation? = nil
+        public var registerFailEx: XCTestExpectation? = nil
         public var interestName: String? = nil
 
         public func subscribedToInterest(name: String) {
@@ -52,6 +53,10 @@ class NativePusherTests: XCTestCase {
             XCTAssertEqual(clientId, testClientId)
             registerEx!.fulfill()
         }
+
+        public func failedToRegisterForPushNotifications(response: URLResponse, responseBody: String?) {
+            registerFailEx!.fulfill()
+        }
     }
 
     var key: String!
@@ -136,6 +141,20 @@ class NativePusherTests: XCTestCase {
         XCTAssertEqual(pusher.nativePusher.requestQueue.count, 1, "the nativePusher request queue should contain the subscribe request")
         XCTAssertEqual(pusher.nativePusher.requestQueue.paused, true, "the nativePusher request queue should be paused")
     }
+
+    func testFailingToRegisterWithPusherForPushNotificationsCallsTheAppropriateDelegateFunction() {
+        let jsonData = "".data(using: String.Encoding.utf8, allowLossyConversion: false)!
+        let url = URL(string: "https://nativepushclient-cluster1.pusher.com/client_api/v1/clients")!
+        let urlResponse = HTTPURLResponse(url: url, statusCode: 500, httpVersion: nil, headerFields: nil)
+        MockSession.addMockResponse(for: url, httpMethod: "POST", data: jsonData, urlResponse: urlResponse, error: nil)
+
+        let registerFailEx = expectation(description: "the appropriate delegate should be called when registration fails")
+        dummyDelegate.registerFailEx = registerFailEx
+
+        pusher.nativePusher.register(deviceToken: "SOME_DEVICE_TOKEN".data(using: String.Encoding.utf8)!)
+
+        waitForExpectations(timeout: 0.5)
+    }
 }
 
 #endif