Error webhook url validation

Author: vivangkumar

lib/pusher/native_notification/client.rb

@@ -7,6 +7,7 @@ class Client
       API_VERSION = "v1"
       GCM_TTL = 241920
       RESTRICTED_GCM_PAYLOAD_KEYS = [:to, :registration_ids]
+      WEBHOOK_LEVELS = ["DEBUG", "INFO"]
 
       def initialize(app_id, host, pusher_client)
         @app_id = app_id
@@ -74,21 +75,18 @@ def validate_payload(payload)
           raise Pusher::Error, "GCM or APNS data must be provided"
         end
 
-        if payload.has_key?(:gcm)
-          gcm_payload = payload[:gcm]
+        if (gcm_payload = payload[:gcm])
+          if (ttl = gcm_payload[:time_to_live])
 
-          if gcm_payload.has_key?(:time_to_live)
-            ttl = gcm_payload[:time_to_live].to_i
-
-            if ttl < 0 || ttl > GCM_TTL
-              raise Pusher::Error, "time_to_live key must have a value between 0 and 241920 (4 weeks)"
+            if ttl.to_i < 0 || ttl.to_i > GCM_TTL
+              raise Pusher::Error, "Time to live must be between 0 and 241920 (4 weeks)"
             end
           end
 
           # If the notification key is provided
           # validate the `icon` and `title`keys
-          if gcm_payload.has_key?(:notification)
-            notification_title, notification_icon = gcm_payload[:notification].values_at(:title, :icon)
+          if (notification = gcm_payload[:notification])
+            notification_title, notification_icon = notification.values_at(:title, :icon)
 
             if (!notification_title || notification_title.empty?)
               raise Pusher::Error, "Notification title is a required field"
@@ -99,6 +97,18 @@ def validate_payload(payload)
             end
           end
         end
+
+        if (webhook_url = payload[:webhook_url])
+          raise Pusher::Error, "Webhook url is invalid" unless webhook_url =~ /\A#{URI::regexp(['http', 'https'])}\z/
+        end
+
+        if (webhook_level = payload[:webhook_level])
+          raise Pusher::Error, "Webhook level cannot be used without a webhook url" if !payload.has_key?(:webhook_url)
+
+          unless WEBHOOK_LEVELS.includes?(webhook_level.upcase)
+            raise Pusher::Error, "Webhook level must either be INFO or DEBUG"
+          end
+        end
       end
 
       # Symbolize all keys in the hash recursively