Merge pull request #8 from pusher/empty-string

Fail if instance_id/secret_key is empty

Author: jonathanlloyd

pusher_push_notifications/__init__.py

@@ -58,8 +58,14 @@ class PushNotifications(object):
     def __init__(self, instance_id, secret_key, endpoint=None):
         if not isinstance(instance_id, six.string_types):
             raise TypeError('instance_id must be a string')
+        if instance_id == '':
+            raise ValueError('instance_id cannot be the empty string')
+
         if not isinstance(secret_key, six.string_types):
             raise TypeError('secret_key must be a string')
+        if secret_key == '':
+            raise ValueError('secret_key cannot be the empty string')
+
         if (endpoint is not None
                 and not isinstance(endpoint, six.string_types)):
             raise TypeError('endpoint must be a string')

tests/test_push_notifications.py

@@ -29,6 +29,14 @@ def test_constructor_should_fail_if_instance_id_not_string(self):
             )
         self.assertIn('instance_id must be a string', str(e.exception))
 
+    def test_constructor_should_fail_if_instance_id_empty_string(self):
+        with self.assertRaises(ValueError) as e:
+            PushNotifications(
+                instance_id='',
+                secret_key='1234',
+            )
+        self.assertIn('instance_id cannot be the empty string', str(e.exception))
+
     def test_constructor_should_fail_if_secret_key_not_string(self):
         with self.assertRaises(TypeError) as e:
             PushNotifications(
@@ -37,6 +45,14 @@ def test_constructor_should_fail_if_secret_key_not_string(self):
             )
         self.assertIn('secret_key must be a string', str(e.exception))
 
+    def test_constructor_should_fail_if_secret_key_empty_string(self):
+        with self.assertRaises(ValueError) as e:
+            PushNotifications(
+                instance_id='1234',
+                secret_key='',
+            )
+        self.assertIn('secret_key cannot be the empty string', str(e.exception))
+
     def test_constructor_should_fail_if_endpoint_not_string(self):
         with self.assertRaises(TypeError) as e:
             PushNotifications(