Merge pull request #4 from pusher/test-errors-correctly-not-json

Test that the SDK errors correctly if the server error is not JSON

Author: jonathanlloyd

tests/test_push_notifications.py

@@ -400,3 +400,29 @@ def test_publish_should_raise_on_http_404_error(self):
                     },
                 )
             self.assertIn('Instance not found: blah', str(e.exception))
+
+
+    def test_publish_should_error_correctly_if_error_not_json(self):
+        pn_client = PushNotifications(
+            'INSTANCE_ID',
+            'SECRET_KEY'
+        )
+        with requests_mock.Mocker() as http_mock:
+            http_mock.register_uri(
+                requests_mock.ANY,
+                requests_mock.ANY,
+                status_code=500,
+                text='<notjson></notjson>',
+            )
+            with self.assertRaises(PusherServerError) as e:
+                pn_client.publish(
+                    interests=['donuts'],
+                    publish_body={
+                        'apns': {
+                            'aps': {
+                                'alert': 'Hello World!',
+                            },
+                        },
+                    },
+                )
+            self.assertIn('Unknown error: no description', str(e.exception))