Skip to content

peadm::convert doesn't update 'PE Master' without rules #574

@vchepkov

Description

@vchepkov

Describe the Bug

The task has the following code fragment:

  def modify_pe_master_rules(rules)
    # If not an array, return as is
    return rules unless rules.is_a?(Array)

It's not clear, why such condition exists, it should at least emit a warning, but, in my case I had no rules defined
so rules is a nil. IMHO, this should be treated as an empty array

Expected Behavior

Plan should add rules if they don't exist

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions