Providers created with pulumi-go-provider don't add version to state even though version is in `/internal/pulumiUtilities.go` in the `PkgResourceDefaultOpts` method

[rshade]

What happened?

Currently providers created with pulumi-go-provider-1.0.2 does not add a version to the state leaving blind version updates, even though the version is in the sdk in /internal/pulumiUtilities.go in the PkgResourceDefaultOpts method

Example

I don't currently have an example.

Output of pulumi about

Pulumi 3.1860
Pulumi-go-provider 1.0.2

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[blampe]

Hi @rshade, there have been a lot of changes to how we handle versioning and I suspect this is a side effect of how you're building/publishing the provider. Can you share the commands you're using to build the provider binary?

It sounds like the SDK step is correctly generating code with the version but the binary isn't getting the correct version embedded.

For reference this is how we build the provider in the native boilerplate

https://github.com/pulumi/pulumi-provider-boilerplate/blob/main/Makefile#L76

cd provider && go build -o $(WORKING_DIR)/bin/${PROVIDER} -ldflags "-X ${PROJECT}/${VERSION_PATH}=${VERSION_GENERIC}" $(PROJECT)/${PROVIDER_PATH}/cmd/$(PROVIDER)

Can you confirm these flags are getting set, and the version path is correct? Can you also share how you're computing the expected version?

[iwahbe]

@blampe as I read it, its not a problem with how the provider is built. I think it's more that we want to enable upgrades to only trigger when they are upgrading from an old version to a new version. How does the current provider know the version of the provider that created a given resource?

@rshade Does that sound correct?

If I remember correctly, this was about upgrades. The proof of concept would be a resource like UpgadeCounter (below). UpgradeCounter should increment Upgrades every time it

type UpgradeCounter struct {}

type UpgradeCounterArgs struct {}

type UpgradeCounterState struct { Upgrades int `pulumi:"upgrades" }

func (UpgradeCounter) Create(
	ctx context.Context, req infer.CreateRequest[UpgradeCounterArgs],
) (infer.CreateResponse[UpgradeCounterState], error) {
	return infer.CreateResponse{ID: req.Name, Output: UpgradeCounterState{}), nil
}

This cannot be done with CustomStateMigrations, since that relies purely on state to understand when a migration should trigger.

[blampe]

Ah thanks @iwahbe, that's my fault for not reading closely.

@rshade are you seeing this with state migrations like in Ian's example?

does not add a version to the state leaving blind version updates

Or is the problem simply that you don't see something like "from v1.xx → to 1.yy" in your diff when the provider is upgraded in code?

[rshade]

It's both, state is empty and preview is blind. I think it might be the go build item though since the version is not in the -X

[blampe]

@rshade try updating using CLI version 3.191, that includes some changes which might help here. I'm separately trying to confirm the fix.