Example code for `getRouteTables` doesn't work

[stooj]

Describe what happened

The example code for aws.ec2.getRouteTables | Pulumi Registry doesn't work because of the loop control.

Sample program

using System.Collections.Generic;
using System.Linq;
using Pulumi;
using Aws = Pulumi.Aws;

return await Deployment.RunAsync(() => 
{
    var rts = Aws.Ec2.GetRouteTables.Invoke(new()
    {
        VpcId = vpcId,
        Filters = new[]
        {
            new Aws.Ec2.Inputs.GetRouteTablesFilterInputArgs
            {
                Name = "tag:kubernetes.io/kops/role",
                Values = new[]
                {
                    "private*",
                },
            },
        },
    });

    var r = new List<Aws.Ec2.Route>();
    for (var rangeIndex = 0; rangeIndex < rts.Apply(getRouteTablesResult => getRouteTablesResult.Ids).Length; rangeIndex++)
    {
        var range = new { Value = rangeIndex };
        r.Add(new Aws.Ec2.Route($"r-{range.Value}", new()
        {
            RouteTableId = rts.Apply(getRouteTablesResult => getRouteTablesResult.Ids)[range.Value],
            DestinationCidrBlock = "10.0.0.0/22",
            VpcPeeringConnectionId = "pcx-0e9a7a9ecd137dc54",
        }));
    }
});

Log output

Error is:

error CS0019: Operator '<' cannot be applied to operands of type 'int' and 'method group' 

Affected Resource(s)

• getRouteTables

Output of pulumi about

This would apply to any version, I think.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[t0yv0]

Thanks for filing this @stooj this is unfortunate, looks like the generated .NET code does not compile here.

I've narrowed this down a bit.

We start with this TF snippet which is mostly correct except for a dangling "vpc_id" reference.

data "aws_route_tables" "rts" {
  vpc_id = var.vpc_id

  filter {
    name   = "tag:kubernetes.io/kops/role"
    values = ["private*"]
  }
}

resource "aws_route" "r" {
  count                     = length(data.aws_route_tables.rts.ids)
  route_table_id            = tolist(data.aws_route_tables.rts.ids)[count.index]
  destination_cidr_block    = "10.0.0.0/22"
  vpc_peering_connection_id = "pcx-0e9a7a9ecd137dc54"
}

This gets converted to the following PCL:

rts = invoke("aws:ec2/getRouteTables:getRouteTables", {
  vpcId = vpcId
  filters = [{
    name   = "tag:kubernetes.io/kops/role"
    values = ["private*"]
  }]
})

resource "r" "aws:ec2/route:Route" {
  options {
    range = length(rts.ids)
  }
  routeTableId           = rts.ids[range.value]
  destinationCidrBlock   = "10.0.0.0/22"
  vpcPeeringConnectionId = "pcx-0e9a7a9ecd137dc54"
}

Translating this to TypeScript generates type-correct code though it is a little strange:

import * as pulumi from "@pulumi/pulumi";
import * as aws from "@pulumi/aws";

const rts = aws.ec2.getRouteTablesOutput({
    vpcId: "OK",
    filters: [{
        name: "tag:kubernetes.io/kops/role",
        values: ["private*"],
    }],
});
const r: aws.ec2.Route[] = [];
rts.apply(rts => rts.ids).length.apply(rangeBody => {
    for (const range = {value: 0}; range.value < rangeBody; range.value++) {
        r.push(new aws.ec2.Route(`r-${range.value}`, {
            routeTableId: rts.apply(rts => rts.ids[range.value]),
            destinationCidrBlock: "10.0.0.0/22",
            vpcPeeringConnectionId: "pcx-0e9a7a9ecd137dc54",
        }));
    }
});

In contrast .NET/C# code does not compile:

using System.Collections.Generic;
using System.Linq;
using Pulumi;
using Aws = Pulumi.Aws;

return await Deployment.RunAsync(() => 
{
    var rts = Aws.Ec2.GetRouteTables.Invoke(new()
    {
        VpcId = vpcId,
        Filters = new[]
        {
            new Aws.Ec2.Inputs.GetRouteTablesFilterInputArgs
            {
                Name = "tag:kubernetes.io/kops/role",
                Values = new[]
                {
                    "private*",
                },
            },
        },
    });

    var r = new List<Aws.Ec2.Route>();
    for (var rangeIndex = 0; rangeIndex < rts.Apply(getRouteTablesResult => getRouteTablesResult.Ids).Length; rangeIndex++)
    {
        var range = new { Value = rangeIndex };
        r.Add(new Aws.Ec2.Route($"r-{range.Value}", new()
        {
            RouteTableId = rts.Apply(getRouteTablesResult => getRouteTablesResult.Ids)[range.Value],
            DestinationCidrBlock = "10.0.0.0/22",
            VpcPeeringConnectionId = "pcx-0e9a7a9ecd137dc54",
        }));
    }
});

I am using these versions:

pulumi version
v3.171.0
terraform         converter  1.2.0    40 MB   5 days ago  5 days ago

Given the behavior above, I think this bug needs to be fixed in the .NET program generator, it should either generate correct code or fail in which case we at least exclude the broken example from the set. Let me transfer the issue.