Skip to content

Commit bf077ed

Browse files
authored
Multi-target netcoreapp3.1 and net6.0 (#69)
1 parent e72c6d6 commit bf077ed

File tree

5 files changed

+15
-7
lines changed

5 files changed

+15
-7
lines changed

CHANGELOG_PENDING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
### Improvements
22

3-
- [revert] Re-introduce support for .NET Core 3.1 via multi-targeting.
4-
[#XX](https://github.com/pulumi/pulumi-dotnet/pull/XX)
3+
- [sdk] Multi-target .NET Core 3.1 and .NET 6.0.
4+
[#69](https://github.com/pulumi/pulumi-dotnet/pull/69)
55

66
### Bug Fixes

integration_tests/integration_util_test.go

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,20 @@ func prepareDotnetProject(projInfo *engine.Projinfo) error {
9292
continue
9393
}
9494

95+
packageReference := fmt.Sprintf(`<ProjectReference Include="%s" />`, pulumiSdkPath)
96+
97+
// If we're running edit tests we might have already have added the ProjectReference (edit tests
98+
// rerun prepareProject)
99+
if strings.Contains(string(projectContent), packageReference) {
100+
continue
101+
}
102+
95103
modifiedContent := fmt.Sprintf(`
96104
<ItemGroup>
97-
<ProjectReference Include="%s" />
105+
%s
98106
</ItemGroup>
99107
</Project>
100-
`, pulumiSdkPath)
108+
`, packageReference)
101109

102110
modifiedProjectContent := strings.ReplaceAll(string(projectContent), "</Project>", modifiedContent)
103111
err = os.WriteFile(projectPath, []byte(modifiedProjectContent), 0644)

sdk/Pulumi.Automation/Pulumi.Automation.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>netcoreapp3.1</TargetFramework>
4+
<TargetFrameworks>netcoreapp3.1;net6.0</TargetFrameworks>
55
<Nullable>enable</Nullable>
66
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
77
<Authors>Pulumi</Authors>

sdk/Pulumi.FSharp/Pulumi.FSharp.fsproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>netcoreapp3.1</TargetFramework>
4+
<TargetFrameworks>netcoreapp3.1;net6.0</TargetFrameworks>
55
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
66
<Authors>Pulumi</Authors>
77
<Company>Pulumi Corp.</Company>

sdk/Pulumi/Pulumi.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>netcoreapp3.1</TargetFramework>
4+
<TargetFrameworks>netcoreapp3.1;net6.0</TargetFrameworks>
55
<Nullable>enable</Nullable>
66
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
77
<Authors>Pulumi</Authors>

0 commit comments

Comments
 (0)