Skip to content

Sync changes to us #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 206 commits into
base: main
Choose a base branch
from
Open

Sync changes to us #8

wants to merge 206 commits into from

Conversation

deleonio
Copy link

@deleonio deleonio commented Sep 7, 2024

No description provided.

liamdebeasi and others added 25 commits March 26, 2024 13:24
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…les (#452)

Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
* feat(react-output-target): generate functional components and ES modules (#432)

* feat: migrate to lit/react component wrappers

* exploration nextjs support

* update Stencil with support for DSD

* get rid of hydration errors

* enhance output target

* add tests

* fix dep

* remove type property in package.json

* remove hydrate dir

* move ssr support into custom export

* clear hydrate folder again

* skip lib check

* skip lib check

* better resolve light dom

* remove unused import

* match default dir with stencil

* more improvements on light dom rendering

* remove duplicate hydrate ot

* remove style prop

* fail if outdir is not set

* import hydration script and ssr runtime only within the server component

* validate hydrate output target to be set if hydrateModule option is set

* improve implementation

* separate files for server and client components

* properly create server and client side components

* don't parse children

* use own runtime

* validate that external runtime is set to 'true'

* adjust test

* update Stencil dev build

* recognise that externalRuntime default is true

* bring back light DOM rendering for better hydration results

* revert light dom approach

* minor formatting

* update stencil

* explicitly type component exports

* unit test tweak

* fix build

* use latest Stencil release

* fix test

---------

Co-authored-by: Sean Perkins <13732623+sean-perkins@users.noreply.github.com>
Co-authored-by: Christian Bromann <git@bromann.dev>
* Provide support for standalone value accessors

* Provide support for standalone value accessors

* Chore: removed console logs and if check changed
…ile (#465)

Co-authored-by: Christian Bromann <git@bromann.dev>
* fix(react): transform react props into HTML ones

* reduce list
* fix(react): decamelize all component props

* make tests pass
Copy link

github-actions bot commented Sep 7, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


6 out of 16 committers have signed the CLA.
✅ (Samg983)[https://github.com/Samg983]
✅ (alexprudhomme)[https://github.com/alexprudhomme]
✅ (ghoullier)[https://github.com/ghoullier]
✅ (CosmicEvil)[https://github.com/CosmicEvil]
✅ (alexandertrefz)[https://github.com/alexandertrefz]
✅ (dwirz)[https://github.com/dwirz]
@liamdebeasi
@brandyscarney
@thetaPC
@sean-perkins
@christian-bromann
@dgonzalezr
@64BitAsura
@kristilw
@baumgm94
@aesteves60
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@Samg983
Copy link

Samg983 commented Sep 11, 2024

I have read the CLA Document and I hereby sign the CLA

@Samg983
Copy link

Samg983 commented Sep 11, 2024

recheck

* Update create-stencil-react-components.ts

* make it work for both react and angular

* Revert "Merge branch 'main' into patch-1"

This reverts commit bee2cdd, reversing
changes made to 14ad86b.

* proper implementation

* fix

* move back in another function

* Update packages/react-output-target/src/react-output-target/utils/string-utils.ts

Co-authored-by: Tanner Reits <47483144+tanner-reits@users.noreply.github.com>

* Update packages/react-output-target/src/react-output-target/utils/string-utils.ts

Co-authored-by: Tanner Reits <47483144+tanner-reits@users.noreply.github.com>

---------

Co-authored-by: Tanner Reits <47483144+tanner-reits@users.noreply.github.com>
@alexprudhomme
Copy link

I have read the CLA Document and I hereby sign the CLA

christian-bromann and others added 30 commits June 16, 2025 09:58
* fix: revert model update event renaming

* fix: lint

---------

Co-authored-by: Christian Bromann <git@bromann.dev>
* made sure to use dist folder for angular library dependency

* Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

* #648 fixed standalone flag not being set correctly for components and scams for angular versions 19 and up

* fixed unused component warnings

* build result

* added angular version table

* fixed tests

* forgot to push  pnpm lock file

---------

Co-authored-by: Alexander Gratzl <alexander.gratzl@solvistas.com>
…mports and improved SSR property serialization

This commit introduces several key improvements to the React output target:

-Enable Next.js users to import both server and client-side components from the same source
- Add browser detection in createComponent to automatically return client-side wrapper when running in browser context
- Remove restrictive import documentation that discouraged server component imports

- Integrate serializeProperty function from hydrate module for better property handling
- Replace primitive-only property serialization with robust serialization that handles complex objects
- Add proper TypeScript support for HydrateModule interface including serializeProperty

- Add additional metadata to generated components: elementClass, react, events, and defineCustomElement
- Enhance type safety with proper event handling and element class references
- Add TypeScript ignore directive to handle potential React type mismatches

- Enable sourcemaps in Vite build configuration for better debugging
- Streamline component wrapper creation with unified options interface

These changes allow developers to write more maintainable code by importing components from a single source while ensuring optimal performance for both server-side and client-side rendering scenarios.
Co-authored-by: Rakesh Pawar <rakesh.pawar@juliusbaer.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.2.0 to 4.4.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@1d0ff46...49933ea)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-version: 4.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update output-angular.ts

Adapt the component arguments to pass information on required inputs.

* Update generate-angular-component.ts

Processing of required inputs. Keep the order, but instead of specify only name, define it as object with required property set to true.

* Removed unused code and fixed the syntax

* Add type for component inputs in Angular

* Use ComponentInputProperty instead of two arrays with input property names.

* Adapt the argument for the createAngularComponentDefinition

* Use name field instead of object so correct text is put in proxy. + prettier

* Fix ordering the properties, as .sort() do not provide any order for objects when used without compare callback. + prettier

* Update proxies.ts after with build.

* Move mapPropName function to utils to avoid code duplication.

* Use mapPropName from utils

* Do not use require in @ProxyCmp, it require string array.

* Update generate-angular-component.test.ts with new parameter type and tests for required inputs.

* Update proxies.ts - remove new syntax from @ProxyCmp.

* Update types.ts - remove last new line
* fix(react): improved SSR for Next.js

* improvements rendering child nodes

* prettier

* remove versions from example packages

* attempt different loading approach

* update server files

* remove clientModule

* import directly

* import package rather than path

* ts-ignore import

* add missing ts ignore line

* fix build

* remove console.logs

* make test more stable

* ignore random socket issue

* ignore more

* revert some unneeded changes
* fix: include outputs in angular component definition

This commit implements a fix for bug:#643 providing IDE support for Angular component outputs

* Add `outputs` property to the component decorator
* Generate correct event emitter types matching interface declarations
* Derive outputs array internally from events parameter for single source of truth
* Update 15 test cases to match new format

* fix: include outputs in angular component definition

This commit implements a fix for bug:#643 providing IDE support for Angular component outputs

* Add `outputs` property to the component decorator
* Generate correct event emitter types matching interface declarations
* Derive outputs array internally from events parameter for single source of truth
* Update 15 test cases to match new format
* feat: implement custom event property as source for v-model

* feat: add `useEventDetail` option

* docs: update README.md & grammar

* style: format code

* test: implement tests for new v-model event attribute use

* feat: refactor code to support path dot syntax & remove `useEventDetail`

* feat: simplify resolve path function

* feat(vue): add nested event to checkbox component to showcase nested v-model support

* test(vue): add e2e tests for checkbox component with nested v-model support

---------

Co-authored-by: John Jenkins <johnljenkins@Hotmail.com>
Co-authored-by: John Jenkins <john.jenkins@nanoporetech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.