Skip to content

Commit c1c5385

Browse files
committed
Refactor: Removed duplicate logic
1 parent 3e1de7e commit c1c5385

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

src/pages/index.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import type { FunctionComponent } from 'react';
88
import React from 'react';
99
import { KoliBriAbbr } from '../components/KoliBriAbbr';
1010
import { useDocsPreferredVersion } from '@docusaurus/theme-common';
11-
import { Version } from '../../shares/version';
11+
import { determinateVersionId } from '../shares/version';
1212

1313
const HomepageHeader: FunctionComponent = () => (
1414
<header className="p-8 grid justify-center">
@@ -26,10 +26,7 @@ const HomepageHeader: FunctionComponent = () => (
2626
);
2727
const HomepageButtons: FunctionComponent = () => {
2828
const docVersion = useDocsPreferredVersion();
29-
const version =
30-
typeof docVersion?.preferredVersion?.name && parseFloat(docVersion?.preferredVersion?.name as Version) < 2
31-
? 'v1'
32-
: 'v2';
29+
const version = determinateVersionId(docVersion);
3330

3431
return (
3532
<div className="grid sm:flex gap-4 justify-center mt-4">

src/shares/version.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
import type VERSIONS from '../../versions.json';
22

33
export type Version = (typeof VERSIONS)[number] & 'current';
4+
5+
export function determinateVersionId(docVersion) {
6+
if (!docVersion || !docVersion.preferredVersion) return null;
7+
return parseFloat(docVersion?.preferredVersion?.name as Version) < 2 ? 'v1' : 'v2';
8+
}

src/theme/Navbar/index.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { LanguageSwitch } from '@site/src/components/LanguageSwitch';
99
import Navbar from '@theme-original/Navbar';
1010
import ThemeSelect from './ThemeSelect';
1111
import { useDocsPreferredVersion } from '@docusaurus/theme-common';
12-
import { Version } from '../../shares/version';
12+
import { determinateVersionId } from '../../shares/version';
1313
import { translate } from '@docusaurus/Translate';
1414

1515
export const NavbarWrapper: FunctionComponent<PropsWithChildren> = (props) => {
@@ -28,10 +28,7 @@ export const NavbarWrapper: FunctionComponent<PropsWithChildren> = (props) => {
2828
// },
2929
// };
3030
const docVersion = useDocsPreferredVersion();
31-
const version =
32-
typeof docVersion?.preferredVersion?.name && parseFloat(docVersion?.preferredVersion?.name as Version) < 2
33-
? 'v1'
34-
: 'v2';
31+
const version = determinateVersionId(docVersion);
3532

3633
return (
3734
<div className="kolibri-navbar-wrapper sticky top-0 z-50 bg-white">

0 commit comments

Comments
 (0)