Wrong second argument for preSave hook during incrementalPatch

[berdyshev]

When calling the doc.incrementalPatch() method, the preSave hook is called with document data as the second argument instead of the RxDocument instance.

See IncrementalWriteQueue class implementation. I don't see the RxDocument instance in the context of this method, so I'm not sure what would be the best way to fix it.

[pubkey]

We do not have a RxDocument instance before the write which is why the docuemnt-data is passed here.

[berdyshev]

thank you @pubkey but the types say that the RxDocument should be there. Should we fix the hook type?
https://github.com/pubkey/rxdb/blob/6ffd6afafe53f1d069971525fd3f2deaaabe8f99/src/types/rx-collection.d.ts#L90C18-L90C42

    preSave(fun: RxCollectionHookCallback<RxDocumentType, OrmMethods, Reactivity>, parallel: boolean): void;

[pubkey]

yes, PR is welcomed.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon. Please update it or it may be closed to keep our repository organized. The best way is to add some more information or make a pull request with a test case. Also you might get help in fixing it at the RxDB Community Chat If you know you will continue working on this, just write any message to the issue (like "ping") to remove the stale tag.