From d1cc165afa7412b284703361ce6a60e593dda817 Mon Sep 17 00:00:00 2001 From: madgamer98 Date: Tue, 19 Dec 2023 11:09:58 -0500 Subject: [PATCH] add separate option for disableProvideHover --- package.json | 5 +++++ src/ConfigurationService.ts | 7 +++++++ src/LanguageServer.ts | 8 ++++++++ 3 files changed, 20 insertions(+) diff --git a/package.json b/package.json index 0fd538e..d814a97 100644 --- a/package.json +++ b/package.json @@ -176,6 +176,11 @@ "default": false, "description": "Enable to disable autocomplete on methods and properties (Modifying requires VSCode reload)" }, + "psalm.disableProvideHover": { + "type": "boolean", + "default": false, + "description": "Enable to disable the providing hover definition on methods and properties (Modifying requires VSCode reload)" + }, "psalm.configPaths": { "type": "array", "items": { diff --git a/src/ConfigurationService.ts b/src/ConfigurationService.ts index 2c07c49..99e5769 100644 --- a/src/ConfigurationService.ts +++ b/src/ConfigurationService.ts @@ -12,6 +12,7 @@ interface Config { psalmScriptPath?: string; psalmScriptArgs?: string[]; disableAutoComplete: boolean; + disableProvideHover: boolean; maxRestartCount: integer; unusedVariableDetection: boolean; enableVerbose: boolean; @@ -28,6 +29,7 @@ export class ConfigurationService { private config: Config = { maxRestartCount: 5, disableAutoComplete: false, + disableProvideHover: false, unusedVariableDetection: false, enableVerbose: false, connectToServerWithTcp: false, @@ -82,6 +84,11 @@ export class ConfigurationService { false ); + this.config.disableProvideHover = workspaceConfiguration.get( + 'disableProvideHover', + false + ); + this.config.maxRestartCount = workspaceConfiguration.get( 'maxRestartCount', 5 diff --git a/src/LanguageServer.ts b/src/LanguageServer.ts index 76c7d5e..81ad3af 100644 --- a/src/LanguageServer.ts +++ b/src/LanguageServer.ts @@ -397,6 +397,14 @@ export class LanguageServer { args.unshift('--enable-autocomplete=false'); } + const disableProvideHover = this.configurationService.get( + 'disableProvideHover' + ); + + if (disableProvideHover) { + args.unshift('--enable-provide-hover=false'); + } + // Are we running psalm or psalm-language-server // if we are runing psalm them we need to forward to psalm-language-server const psalmHasLanguageServerOption: boolean =