Merge pull request #175 from prysmex/tooltip-scroll-fix

betocantu93 · web-flow · commit 209ba6b6288b · 2022-11-25T14:40:03.000-06:00
fix: tooltip not repositioning when scrolling
diff --git a/packages/core/addon/components/eui-tool-tip-popover/index.ts b/packages/core/addon/components/eui-tool-tip-popover/index.ts
@@ -16,12 +16,14 @@ export default class EuiTooltipPopover extends Component<EuiTooltipPopoverArgs>
     super(owner, args);
     document.body.classList.add('euiBody-hasPortalContent');
     window.addEventListener('resize', this.updateDimensions);
+    window.addEventListener('scroll', this.updateDimensions, true);
   }
 
   willDestroy(): void {
     super.willDestroy();
     document.body.classList.remove('euiBody-hasPortalContent');
     window.removeEventListener('resize', this.updateDimensions);
+    window.removeEventListener('scroll', this.updateDimensions, true);
   }
 
   @action

Original file line number	Diff line number	Diff line change
`@@ -16,12 +16,14 @@ export default class EuiTooltipPopover extends Component<EuiTooltipPopoverArgs>`
`16`	`16`	`super(owner, args);`
`17`	`17`	`document.body.classList.add('euiBody-hasPortalContent');`
`18`	`18`	`window.addEventListener('resize', this.updateDimensions);`
	`19`	`+ window.addEventListener('scroll', this.updateDimensions, true);`
`19`	`20`	`}`
`20`	`21`
`21`	`22`	`willDestroy(): void {`
`22`	`23`	`super.willDestroy();`
`23`	`24`	`document.body.classList.remove('euiBody-hasPortalContent');`
`24`	`25`	`window.removeEventListener('resize', this.updateDimensions);`
	`26`	`+ window.removeEventListener('scroll', this.updateDimensions, true);`
`25`	`27`	`}`
`26`	`28`
`27`	`29`	`@action`