fixes (#80)

betocantu93 · web-flow · commit 0cb8e2137671 · 2022-01-21T20:33:11.000-06:00
* fix: ember-svg-jar

* fix: demo

* v1.3.4
diff --git a/docs/installation.md b/docs/installation.md
@@ -33,14 +33,14 @@ var app = new EmberApp(defaults, {
 
 ```
 
-We use `ember-svg-jar` to create SVGs as TOC (Template only components) with the `hbs` strategy. For fingerprinting and such, `ember-svg-jar#add-bundle-flag` exposes an `svg-jar` service, with a `resolveAsset` callback/hook, so you can implement your own resolver, you could use for example [ember-cli-resolve-assset](https://github.com/buschtoens/ember-cli-resolve-asset).
+We use `ember-svg-jar` to create SVGs as TOC (Template only components) with the `hbs` strategy. For fingerprinting and such, `ember-svg-jar#add-bundle-flag` exposes an `asset-map` service, with a `resolve` callback/hook, so you can implement your own resolver, you could use for example [ember-cli-resolve-assset](https://github.com/buschtoens/ember-cli-resolve-asset).
 
 ```javascript
-import EmberSvgJarService from 'ember-svg-jar/services/svg-jar';
+import EmberSvgJarService from 'ember-svg-jar/services/asset-map';
 import resolveAsset from 'ember-cli-resolve-asset'
 
 export default class SvgJarService extends EmberSvgJarService {
-  resolveAsset(path) {
+  resolve(path) {
     //Here you could implement, for instance ember-cli-ifa, instead of ember-cli-resolve-asset.
     return resolveAsset(path);
   }
diff --git a/lerna.json b/lerna.json
@@ -1,5 +1,5 @@
 {
-  "version": "1.3.3",
+  "version": "1.3.4",
   "packages": [
     "packages/*"
   ],
diff --git a/packages/changeset-form/package.json b/packages/changeset-form/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ember-eui/changeset-form",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "description": "Ember Eui changeset integration",
   "keywords": [
     "ember-addon",
@@ -27,7 +27,7 @@
     "postpack": "ember ts:clean"
   },
   "dependencies": {
-    "@ember-eui/core": "^1.3.3",
+    "@ember-eui/core": "^1.3.4",
     "@types/ember": "^3.16.4",
     "ember-changeset": "github:betocantu93/ember-changeset#spike-fix-prop-notification",
     "ember-changeset-validations": "github:betocantu93/ember-changeset-validations#spike-fix-prop-notification-with-no-mutation",
diff --git a/packages/changeset-form/tests/dummy/app/services/asset-map.js b/packages/changeset-form/tests/dummy/app/services/asset-map.js
@@ -1,8 +1,8 @@
-import EmberSvgJarService from 'ember-svg-jar/services/svg-jar';
+import EmberSvgJarService from 'ember-svg-jar/services/asset-map';
 import resolveAsset from 'ember-cli-resolve-asset';
 
 export default class SvgJar extends EmberSvgJarService {
-  resolveAsset(path) {
+  resolve(path) {
     return resolveAsset(path);
   }
 }
diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ### Master
 
+### 1.3.4
+🐛 Bug / Fixes
+- Fix docs related to ember-svg-jar and netlify demo
+
 ### 1.3.0 - 1.3.3
 🐛 Bug / Fixes
 - Ts bugs
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ember-eui/core",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "description": "Ember Components for Elastic UI",
   "keywords": [
     "ember-addon",
@@ -77,9 +77,6 @@
     "ember-style-modifier": "^0.6.0",
     "ember-svg-jar": "https://github.com/betocantu93/ember-svg-jar.git#add-bundle-flag",
     "ember-truth-helpers": "^2.1.0",
-    "resolve": "^1.13.1"
-  },
-  "peerDependencies": {
     "highlight.js": "^9.18.5",
     "lodash-es": "^4.17.21",
     "mdast-util-to-hast": "^10.0.0",
@@ -90,6 +87,7 @@
     "remark-highlight.js": "^6.0.0",
     "remark-parse": "^8.0.3",
     "remark-rehype": "^8.0.0",
+    "resolve": "^1.13.1",
     "tabbable": "^5.1.5",
     "unified": "^9.2.0",
     "vfile": "^4.2.0"
@@ -133,24 +131,13 @@
     "eslint-plugin-ember": "^8.9.1",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^3.3.1",
-    "highlight.js": "^9.18.5",
     "loader.js": "^4.7.0",
     "lodash-es": "^4.17.21",
     "mdast-util-to-hast": "^10.0.0",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.2.1",
     "qunit-dom": "^1.2.0",
-    "rehype-raw": "^5.0.0",
-    "rehype-stringify": "^8.0.0",
-    "remark-breaks": "^3.0.2",
-    "remark-emoji": "^2.1.0",
-    "remark-highlight.js": "^6.0.0",
-    "remark-parse": "^8.0.3",
-    "remark-rehype": "^8.0.0",
-    "tabbable": "^5.1.5",
-    "typescript": "^4.0.3",
-    "unified": "^9.2.0",
-    "vfile": "^4.2.0"
+    "typescript": "^4.0.3"
   },
   "publishConfig": {
     "access": "public"
diff --git a/packages/core/tests/dummy/app/services/asset-map.js b/packages/core/tests/dummy/app/services/asset-map.js
@@ -1,8 +1,8 @@
-import EmberSvgJarService from 'ember-svg-jar/services/svg-jar';
+import EmberSvgJarService from 'ember-svg-jar/services/asset-map';
 import resolveAsset from 'ember-cli-resolve-asset';
 
 export default class SvgJar extends EmberSvgJarService {
-  resolveAsset(path) {
+  resolve(path) {
     return resolveAsset(path);
   }
 }
diff --git a/packages/pikaday/package.json b/packages/pikaday/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ember-eui/pikaday",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "description": "ember-pikaday integration with @ember-eui/core",
   "keywords": [
     "ember-addon",
@@ -28,7 +28,7 @@
   },
   "dependencies": {
     "@ember-decorators/component": "^6.1.0",
-    "@ember-eui/core": "^1.3.3",
+    "@ember-eui/core": "^1.3.4",
     "@types/ember": "^3.16.4",
     "ember-cli-babel": "^7.21.0",
     "ember-cli-htmlbars": "^5.2.0",
diff --git a/packages/pikaday/tests/dummy/app/services/asset-map.js b/packages/pikaday/tests/dummy/app/services/asset-map.js
@@ -1,8 +1,8 @@
-import EmberSvgJarService from 'ember-svg-jar/services/svg-jar';
+import EmberSvgJarService from 'ember-svg-jar/services/asset-map';
 import resolveAsset from 'ember-cli-resolve-asset';
 
 export default class SvgJar extends EmberSvgJarService {
-  resolveAsset(path) {
+  resolve(path) {
     return resolveAsset(path);
   }
 }
diff --git a/packages/validated-form/package.json b/packages/validated-form/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ember-eui/validated-form",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "description": "The default blueprint for ember-cli addons.",
   "keywords": [
     "ember-addon"
@@ -25,7 +25,7 @@
     "postpack": "ember ts:clean"
   },
   "dependencies": {
-    "@ember-eui/core": "^1.3.3",
+    "@ember-eui/core": "^1.3.4",
     "ember-cli-babel": "^7.21.0",
     "ember-cli-htmlbars": "^5.2.0",
     "ember-cli-typescript": "^4.1.0",
diff --git a/packages/validated-form/tests/dummy/app/services/asset-map.js b/packages/validated-form/tests/dummy/app/services/asset-map.js
@@ -1,8 +1,8 @@
-import EmberSvgJarService from 'ember-svg-jar/services/svg-jar';
+import EmberSvgJarService from 'ember-svg-jar/services/asset-map';
 import resolveAsset from 'ember-cli-resolve-asset';
 
 export default class SvgJar extends EmberSvgJarService {
-  resolveAsset(path) {
+  resolve(path) {
     return resolveAsset(path);
   }
 }
diff --git a/site/app/services/asset-map.js b/site/app/services/asset-map.js
@@ -0,0 +1,8 @@
+import EmberSvgJarService from 'ember-svg-jar/services/asset-map';
+import resolveAsset from 'ember-cli-resolve-asset';
+
+export default class SvgJar extends EmberSvgJarService {
+  resolve(path) {
+    return resolveAsset(path);
+  }
+}
diff --git a/site/app/services/svg-jar.js b/site/app/services/svg-jar.js
diff --git a/site/package.json b/site/package.json
@@ -1,6 +1,6 @@
 {
   "name": "site",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "private": true,
   "description": "Small description for site goes here",
   "repository": "https://github.com/prysmex/ember-eui",
@@ -72,10 +72,10 @@
     "edition": "octane"
   },
   "dependencies": {
-    "@ember-eui/changeset-form": "^1.3.3",
-    "@ember-eui/core": "^1.3.3",
-    "@ember-eui/pikaday": "^1.3.3",
-    "@ember-eui/validated-form": "^1.3.3",
+    "@ember-eui/changeset-form": "^1.3.4",
+    "@ember-eui/core": "^1.3.4",
+    "@ember-eui/pikaday": "^1.3.4",
+    "@ember-eui/validated-form": "^1.3.4",
     "@fullhuman/postcss-purgecss": "^4.0.2",
     "autoprefixer": "^10.2.5",
     "ember-cli-resolve-asset": "^0.3.0",

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "version": "1.3.3",`
	`2`	`+ "version": "1.3.4",`
`3`	`3`	`"packages": [`
`4`	`4`	`"packages/*"`
`5`	`5`	`],`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`		`-import EmberSvgJarService from 'ember-svg-jar/services/svg-jar';`
	`1`	`+import EmberSvgJarService from 'ember-svg-jar/services/asset-map';`
`2`	`2`	`import resolveAsset from 'ember-cli-resolve-asset';`
`3`	`3`
`4`	`4`	`export default class SvgJar extends EmberSvgJarService {`
`5`		`- resolveAsset(path) {`
	`5`	`+ resolve(path) {`
`6`	`6`	`return resolveAsset(path);`
`7`	`7`	`}`
`8`	`8`	`}`