Skip to content

Commit a8bc00a

Browse files
authored
Merge pull request #127 from proximax-storage/issue/mosaic_prop_builder_init
fixed initialization of mosaic account property builder
2 parents 09da701 + 881a356 commit a8bc00a

File tree

4 files changed

+21
-3
lines changed

4 files changed

+21
-3
lines changed

src/main/java/io/proximax/sdk/model/transaction/builder/ModifyAccountPropertyMosaicTransactionBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77

88
import java.math.BigInteger;
99

10-
import io.proximax.sdk.model.transaction.ModifyAccountPropertyTransaction;
1110
import io.proximax.sdk.model.transaction.EntityType;
1211
import io.proximax.sdk.model.transaction.EntityVersion;
12+
import io.proximax.sdk.model.transaction.ModifyAccountPropertyTransaction;
1313
import io.proximax.sdk.model.transaction.UInt64Id;
1414

1515
/**
@@ -18,7 +18,7 @@
1818
public class ModifyAccountPropertyMosaicTransactionBuilder extends ModifyAccountPropertyTransactionBuilder<UInt64Id> {
1919

2020
public ModifyAccountPropertyMosaicTransactionBuilder() {
21-
super(EntityType.ACCOUNT_PROPERTIES_ADDRESS, EntityVersion.ACCOUNT_PROPERTIES_ADDRESS.getValue());
21+
super(EntityType.ACCOUNT_PROPERTIES_MOSAIC, EntityVersion.ACCOUNT_PROPERTIES_MOSAIC.getValue());
2222
}
2323

2424
@Override

src/test/java/io/proximax/sdk/model/transaction/builder/ModifyAccountPropertyAddressTransactionBuilderTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import io.proximax.sdk.model.account.props.AccountPropertyModification;
2121
import io.proximax.sdk.model.account.props.AccountPropertyType;
2222
import io.proximax.sdk.model.blockchain.NetworkType;
23+
import io.proximax.sdk.model.transaction.EntityType;
2324
import io.proximax.sdk.model.transaction.ModifyAccountPropertyTransaction;
2425

2526
/**
@@ -39,6 +40,11 @@ void setUp() {
3940
builder.feeCalculationStrategy(FeeCalculationStrategy.MEDIUM);
4041
}
4142

43+
@Test
44+
void checkBuilder() {
45+
assertEquals(EntityType.ACCOUNT_PROPERTIES_ADDRESS, builder.getType());
46+
}
47+
4248
@Test
4349
void test() {
4450
Address addr = new Account(new KeyPair(), NETWORK_TYPE).getAddress();

src/test/java/io/proximax/sdk/model/transaction/builder/ModifyAccountPropertyEntityTransactionBuilderTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
import io.proximax.sdk.model.account.props.AccountPropertyModification;
1818
import io.proximax.sdk.model.account.props.AccountPropertyType;
1919
import io.proximax.sdk.model.blockchain.NetworkType;
20-
import io.proximax.sdk.model.transaction.ModifyAccountPropertyTransaction;
2120
import io.proximax.sdk.model.transaction.EntityType;
21+
import io.proximax.sdk.model.transaction.ModifyAccountPropertyTransaction;
2222

2323
/**
2424
* {@link ModifyAccountPropertyEntityTransactionBuilder} tests
@@ -37,6 +37,11 @@ void setUp() {
3737
builder.feeCalculationStrategy(FeeCalculationStrategy.MEDIUM);
3838
}
3939

40+
@Test
41+
void checkBuilder() {
42+
assertEquals(EntityType.ACCOUNT_PROPERTIES_ENTITY_TYPE, builder.getType());
43+
}
44+
4045
@Test
4146
void test() {
4247
AccountPropertyModification<EntityType> mod = AccountPropertyModification.add(EntityType.MODIFY_CONTRACT);

src/test/java/io/proximax/sdk/model/transaction/builder/ModifyAccountPropertyMosaicTransactionBuilderTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import io.proximax.sdk.model.account.props.AccountPropertyType;
1919
import io.proximax.sdk.model.blockchain.NetworkType;
2020
import io.proximax.sdk.model.mosaic.MosaicId;
21+
import io.proximax.sdk.model.transaction.EntityType;
2122
import io.proximax.sdk.model.transaction.ModifyAccountPropertyTransaction;
2223
import io.proximax.sdk.model.transaction.UInt64Id;
2324

@@ -38,12 +39,18 @@ void setUp() {
3839
builder.feeCalculationStrategy(FeeCalculationStrategy.MEDIUM);
3940
}
4041

42+
@Test
43+
void checkBuilder() {
44+
assertEquals(EntityType.ACCOUNT_PROPERTIES_MOSAIC, builder.getType());
45+
}
46+
4147
@Test
4248
void test() {
4349
MosaicId mosid = new MosaicId(BigInteger.ONE);
4450
AccountPropertyModification<UInt64Id> mod = AccountPropertyModification.add(mosid);
4551
ModifyAccountPropertyTransaction<UInt64Id> trans = builder.propertyType(AccountPropertyType.ALLOW_MOSAIC).modifications(Arrays.asList(mod)).build();
4652

53+
assertEquals(EntityType.ACCOUNT_PROPERTIES_MOSAIC, trans.getType());
4754
assertEquals(AccountPropertyType.ALLOW_MOSAIC, trans.getPropertyType());
4855
assertEquals(1, trans.getPropertyModifications().size());
4956
assertEquals(mod, trans.getPropertyModifications().get(0));

0 commit comments

Comments
 (0)