gap detection can be defined in central projection config

Author: unixslayer

.php_cs renamed to .php-cs-fixer.php

@@ -293,6 +293,9 @@ prooph_event_store:
                         lock_timeout_ms: 1000
                         trigger_pcntl_dispatch: false
                         update_lock_threshold: 0
+                        gap_detection:
+                            retry_config: [0, 5, 10, 15, 30, 60, 90]
+                            detection_window: 'P1M'
 ```
 
 ### Tagged service

doc/projection_manager.md

@@ -13,10 +13,30 @@
 
 namespace Prooph\Bundle\EventStore\Projection\Options;
 
+use Prooph\EventStore\Pdo\Projection\GapDetection;
+use Prooph\EventStore\Pdo\Projection\PdoEventStoreProjector;
+
 final class ProjectionOptionsFactory
 {
-    public static function createProjectionOptions(array $options): ProjectionOptions
+    public static function createProjectionOptions(array $config): ProjectionOptions
+    {
+        \array_walk($config, ['self', 'mapOptions']);
+
+        return new ProjectionOptions($config);
+    }
+
+    private static function mapOptions(&$value, string $key): void
     {
-        return new ProjectionOptions($options);
+        if ($key === PdoEventStoreProjector::OPTION_GAP_DETECTION) {
+            $value = self::createGapDetection($value);
+        }
+    }
+
+    private static function createGapDetection(array $config): GapDetection
+    {
+        $retryConfig = $config['retry_config'] ?? null;
+        $detectionWindow = $config['detection_window'] ? new \DateInterval($config['detection_window']) : null;
+
+        return new GapDetection($retryConfig, $detectionWindow);
     }
 }

src/Projection/Options/ProjectionOptionsFactory.php

@@ -12,7 +12,15 @@ prooph_event_store:
                     projection: ProophTest\Bundle\EventStore\Command\Fixture\Projection\BlackHoleReadModelProjection
                     read_model: ProophTest\Bundle\EventStore\Command\Fixture\Projection\BlackHoleReadModel
                     options:
-                        sleep: 10
+                        cache_size: 666
+                        sleep: 666
+                        persist_block_size: 666
+                        lock_timeout_ms: 666
+                        trigger_pcntl_dispatch: false
+                        update_lock_threshold: 0
+                        gap_detection:
+                            retry_config: [0, 5, 10, 15, 30, 60, 90]
+                            detection_window: 'P1M'
 
 services:
     Prooph\EventStore\InMemoryEventStore:

test/Command/Fixture/config/projections.yml

@@ -73,7 +73,7 @@ public function it_does_not_allow_tags_without_projection_name(): void
     }
 
     /** @test */
-    public function it_registers_tagged_projection_optionss()
+    public function it_registers_tagged_projection_options(): void
     {
         $this->registerProjectionOptions(
             'foo.projection_options',

test/DependencyInjection/Compiler/ProjectionOptionsPassTest.php

@@ -9,6 +9,17 @@ prooph_event_store:
         todo_projection:
           read_model: 'ProophTest\Bundle\EventStore\DependencyInjection\Fixture\Projection\TodoReadModel'
           projection: 'ProophTest\Bundle\EventStore\DependencyInjection\Fixture\Projection\TodoProjection'
+          options:
+            cache_size: 1000
+            sleep: 100000
+            persist_block_size: 1000
+            lock_timeout_ms: 1000
+            trigger_pcntl_dispatch: false
+            update_lock_threshold: 0
+            gap_detection:
+              retry_config: [0, 5, 10, 15, 30, 60, 90]
+              detection_window: 'P1M'
+
 
 services:
   Prooph\EventStore\InMemoryEventStore:

test/DependencyInjection/Fixture/config/yml/projections.yml

@@ -0,0 +1,55 @@
+<?php
+
+/**
+ * This file is part of prooph/event-store-symfony-bundle.
+ * (c) 2014-2021 Alexander Miertsch <kontakt@codeliner.ws>
+ * (c) 2015-2021 Sascha-Oliver Prolic <saschaprolic@googlemail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ProophTest\Bundle\EventStore\Projection\Options;
+
+use PHPUnit\Framework\TestCase;
+use Prooph\Bundle\EventStore\Projection\Options\ProjectionOptions;
+use Prooph\Bundle\EventStore\Projection\Options\ProjectionOptionsFactory;
+use Prooph\EventStore\Pdo\Projection\GapDetection;
+
+class ProjectionOptionsFactoryTest extends TestCase
+{
+    /**
+     * @test
+     */
+    public function it_creates_projection_options_instance(): void
+    {
+        $config = [
+            'cache_size' => 1000,
+            'sleep' => 100000,
+            'persist_block_size' => 1000,
+            'lock_timeout_ms' => 1000,
+            'trigger_pcntl_dispatch' => false,
+            'update_lock_threshold' => 0,
+            'gap_detection' => [
+                'retry_config' => [0, 5, 10, 15, 30],
+                'detection_window' => 'P5M',
+            ],
+        ];
+
+        $options = ProjectionOptionsFactory::createProjectionOptions($config);
+
+        $expected = new ProjectionOptions([
+            'cache_size' => 1000,
+            'sleep' => 100000,
+            'persist_block_size' => 1000,
+            'lock_timeout_ms' => 1000,
+            'trigger_pcntl_dispatch' => false,
+            'update_lock_threshold' => 0,
+            'gap_detection' => new GapDetection([0, 5, 10, 15, 30], new \DateInterval('P5M')),
+        ]);
+
+        self::assertEquals($expected, $options);
+    }
+}