Remove agent from schedule during SimultaneousActivation

[clarkpetri]

A model I originally built with RandomActivation has the following code for when an agent selects a move which is an exit:

Everything works fine with RandomActivation. In a desire to explore SimultaneousActivation I split out the agent_step to include an advance(self) function. If I leave the model as RandomActivation everything works. However, upon running the model with SimultaneousActivation when an agent reaches an exit and should be removed I receive the following error:

Line 273 is the model's step function.

That key error (11, 15) makes no sense to me. It isn't the location of the agent in question, nor a position the agent started in or even occupied. Any input on understanding this error, a correction, and ultimately removing agents from the model/schedule in SimultaneousActivation is appreciated.

[rht]

You can make it work by adding agent_keys = list(self._agents.keys()) after this line

mesa/mesa/time.py

Line 147 in 54f76b4

self._agents[agent_key].step()

.

[clarkpetri]

It did not work. Following error:

:

The code you originally advised is line 149 in time.py. I made the suggest changes to lines 147 and 151 and commented out 149, receiving the above error. Code looked like:

I'm happy to keep trouble shooting and trying things for you. Of course if I implemented the suggestion incorrectly, please let me know. Because I wasn't definitively certain if you wanted both changed or not, I did try it with 147 changed but the original line 151 and received the same error (which I expected based on my understanding of what's happening).

[rht]

Yes, your implementation is what I would do myself. Looks like the only viable option is to use my original solution.

[clarkpetri]

Sounds good and thanks again for the assist.

[rht]

I made #1391. The SimultaneousActivation is already known to work, but not sure for the StagedActivation one. I wonder if you can test the latter (check the PR for the implementation). Also, SimultaneousActivation is the special case of StagedActivation.

[clarkpetri]

Yes, StagedActivation worked with line 205 from the PR added to my local time.py file and my model's activation updated accordingly. Also, good to know about the special case. Makes sense when I think about it.