Prefer if x.blank? over unless x.present?

Author: jcoyne

.rubocop_todo.yml

@@ -339,21 +339,6 @@ Rails/ApplicationMailer:
 Rails/ApplicationRecord:
   Enabled: false
 
-# Offense count: 10
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
-Rails/Blank:
-  Exclude:
-    - 'app/controllers/spotlight/exhibits_controller.rb'
-    - 'app/helpers/spotlight/application_helper.rb'
-    - 'app/jobs/spotlight/add_uploads_from_csv.rb'
-    - 'app/models/spotlight/featured_image.rb'
-    - 'app/models/spotlight/page.rb'
-    - 'app/models/spotlight/resources/iiif_manifest.rb'
-    - 'app/models/spotlight/resources/iiif_service.rb'
-    - 'lib/migration/iiif.rb'
-    - 'spec/support/features/test_features_helpers.rb'
-
 # Offense count: 4
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Rails/CompactBlank:

app/controllers/spotlight/exhibits_controller.rb

@@ -115,7 +115,7 @@ def import_exhibit_params
     end
 
     def build_initial_exhibit_contact_emails
-      @exhibit.contact_emails.build unless @exhibit.contact_emails.present?
+      @exhibit.contact_emails.build if @exhibit.contact_emails.blank?
     end
   end
 end

app/helpers/spotlight/application_helper.rb

@@ -97,7 +97,7 @@ def render_document_class(document = @document)
     # Return a copy of the blacklight configuration
     # that only includes views conifgured by our block
     def blacklight_view_config_for_search_block(block)
-      return {} unless block.view.present?
+      return {} if block.view.blank?
 
       # Reject any views that aren't configured to display for this block
       blacklight_config.view.select do |view, _|

app/jobs/spotlight/add_uploads_from_csv.rb

@@ -40,7 +40,7 @@ def resources(csv_data, exhibit)
 
       encoded_csv(csv_data).each do |row|
         url = row.delete('url')
-        next unless url.present?
+        next if url.blank?
 
         resource = Spotlight::Resources::Upload.new(
           data: row,

app/models/spotlight/featured_image.rb

@@ -36,7 +36,7 @@ class FeaturedImage < ActiveRecord::Base
     attr_accessor :upload_id
 
     def iiif_url
-      return unless iiif_service_base.present?
+      return if iiif_service_base.blank?
 
       [iiif_service_base, iiif_region || 'full', image_size.join(','), '0', 'default.jpg'].join('/')
     end

app/models/spotlight/page.rb

@@ -129,7 +129,7 @@ def should_display_title?
     end
 
     def lock!(user)
-      create_lock(by: user).tap(&:current_session!) unless lock.present?
+      create_lock(by: user).tap(&:current_session!) if lock.blank?
     end
 
     def updated_after?(other_page)

app/models/spotlight/resources/iiif_manifest.rb

@@ -89,7 +89,7 @@ def add_metadata
 
       def manifest_metadata
         metadata = metadata_class.new(manifest).to_solr
-        return {} unless metadata.present?
+        return {} if metadata.blank?
 
         create_sidecars_for(*metadata.keys)
 
@@ -203,7 +203,7 @@ def metadata
         end
 
         def metadata_hash
-          return {} unless metadata.present?
+          return {} if metadata.blank?
           return {} unless metadata.is_a?(Array)
 
           metadata.each_with_object({}) do |md, hash|

app/models/spotlight/resources/iiif_service.rb

@@ -61,7 +61,7 @@ def recursive_manifests(thing, &block)
 
           thing.manifests.each(&block)
 
-          return unless thing.collections.present?
+          return if thing.collections.blank?
 
           thing.collections.each do |collection|
             recursive_manifests(collection, &block)

lib/migration/iiif.rb

@@ -97,7 +97,7 @@ def update_iiif_url(image)
     end
 
     def coordinates(image)
-      return unless image.image_crop_x.present?
+      return if image.image_crop_x.blank?
 
       [image.image_crop_x, image.image_crop_y, image.image_crop_w, image.image_crop_h].join(',')
     end

spec/support/features/test_features_helpers.rb

@@ -46,7 +46,7 @@ def add_widget(type)
     end
 
     def click_add_widget
-      unless all('.st-block-replacer').present?
+      if all('.st-block-replacer').blank?
         expect(page).to have_css('.st-block-addition')
         first('.st-block-addition').click
       end