fix lint

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>

Author: sozercan

.golangci.yml

@@ -14,7 +14,7 @@ linters:
   disable-all: true
   enable:
     - errcheck
-    - exportloopref
+    - copyloopvar
     - forcetypeassert
     - gocritic
     - goconst

integration/patch_test.go

@@ -47,7 +47,6 @@ func TestPatch(t *testing.T) {
 	require.NoError(t, err)
 
 	for _, img := range images {
-		img := img
 		// Oracle tends to throw false positives with Trivy
 		// See https://github.com/aquasecurity/trivy/issues/1967#issuecomment-1092987400
 		if !reportFile && !strings.Contains(img.Image, "oracle") {

pkg/buildkit/buildkit_test.go

@@ -271,7 +271,6 @@ func TestArrayFile(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.desc, func(t *testing.T) {
 			b := ArrayFile(tt.input)
 			assert.Equal(t, tt.expected, string(b))

pkg/pkgmgr/dpkg.go

@@ -101,9 +101,9 @@ func getDPKGStatusType(b []byte) dpkgStatusType {
 		return DPKGStatusNone
 	}
 
-	st, err := strconv.Atoi(string(b))
+	st, err := strconv.ParseUint(string(b), 10, 32)
 	if err != nil {
-		st = int(DPKGStatusNone)
+		st = uint64(DPKGStatusNone)
 	}
 
 	// convert ascii digit to byte
@@ -407,12 +407,12 @@ func (dm *dpkgManager) unpackAndMergeUpdates(ctx context.Context, updates unvers
 				`bash`, `-c`, `
 							json_str=$PACKAGES_PRESENT
 							update_packages=""
-	
+
 							while IFS=':' read -r package version; do
 								pkg_name=$(echo "$package" | sed 's/^"\(.*\)"$/\1/')
 								pkg_version=$(echo "$version" | sed 's/^"\(.*\)"$/\1/')
 								latest_version=$(apt show $pkg_name 2>/dev/null | awk -F ': ' '/Version:/{print $2}')
-	
+
 								if [ "$latest_version" != "$pkg_version" ]; then
 									update_packages="$update_packages $pkg_name"
 								fi

test/e2e/plugin_test.go

@@ -27,12 +27,11 @@ func TestPlugins(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
 		t.Run(tc.image, func(t *testing.T) {
 			t.Parallel()
 			_, err := runPatch(tc.image, tc.report)
 			if err != nil {
-				assert.Equal(t, tc.err, fmt.Errorf(err.Error()))
+				assert.Equal(t, tc.err, fmt.Errorf("%s", err.Error()))
 			} else {
 				assert.Equal(t, tc.err, nil)
 			}