Add an addFace function that adds a face to the current geometry object

[simon-glitch]

Increasing access

This would make is easier to make completely custom 3D objects, by adding a new means of doing so.

Most appropriate sub-area of p5.js?

• Accessibility
• Color
• Core/Environment/Rendering
• Data
• DOM
• Events
• Image
• IO
• Math
• Typography
• Utilities
• WebGL
• Build process
• Unit testing
• Internationalization
• Friendly errors
• Other (specify if possible)

Feature request details

The function could have two version. addFace(indices), which takes a list of indices for the vertices you want to add. And add addFace(vectors), which takes in a list of vectors and automatically figures out which indices those vectors should be replaced with and extends the internal list of vertices for the geometry if necessary. I really want the latter one because it requires the least thought for me. And it's not too hard to use a JS object to accomplish this, so don't complain to me about it requiring a search through a list. It does not require one. Just use a JS object. Also also, I want to be able to input 4 indices / vectos at a time, and it will automatically sort them and split the quad into 2 triangles. How should they be sorted? I dunno, just pick some arbitrary rule. I just want to be able to use the function.

[Iron-56]

Hello there, I would like to work on this issue, can you please assign it to me @simon-glitch ? I am quite new to open source contribution but I know some js and WebGL. Looking forward to make the PR and implement the feature!
@ksen0

[simon-glitch]

@Iron-56 , I'm not a contributer to the project, so I can't assign it to you. If you want to contribute, just make a fork, edit / add code, and then make a pull request.

[ksen0]

Hi @Iron-56 @simon-glitch , thanks for the idea and the interest!

Because there's a lot of other ongoing work, additions to the API can only be considered in the future (current work described here, plus bigfixes). When new features can be considered, it would also be helpful to elaborate ab it how this feature increases access (you can read more here what that means, I'm happy to answer any questions).

One thing you can do anytime, though, is create an add-on library compatible with p5.js 2.x that makes addFace available. One it's available, you're welcome to add it to the directory by making a PR on the website. This means can allow you to experiment with both API design and implementation before proposing to add it to the core library.

This issue can stay open and you're welcome to use it to share your ideas, get feedback, or provide an update from your add-on library if you decide to go in that direction!

[Iron-56]

Thank you @ksen0 I really appreciate the resources you gave and I got a bit of overview of what needs to be done. I think we need to enhance the accessibility instead of introducing new functions currently. I also feel that this issue can stay open.

[simon-glitch]

Okay, guys. I actually looked into a bit, and it seems that Geometry objects don't even have a proper faces list. Instead, they make the faces based on whatever component objects they're made of. So my proposed change would require adding functions for triangle3d and polygon3d as well. And I think I actually will try to make an add-on for this, because I am personally interested and would find these functions useful. Also, yes, this issue is quite unimportant. I'm just making this feautre request because it would add a new way to construct geometry objects, which would have new and interesting use-cases.

[ksen0]

Thanks for the follow-up @simon-glitch ! I'll keep this open then, in case others want to comment with their ideas/needs - and if you work on an add-on library, please do share your progress here.