Skip to content

QueryStream into_result doesn't return correct number of results #380

@ZemanOndrej

Description

@ZemanOndrej

this ruins queries with multiple select statements because if one select returns nothing you cant know which select it was

pub async fn into_results(mut self) -> crate::Result<Vec<Vec<Row>>> {
let mut results: Vec<Vec<Row>> = Vec::new();
let mut result: Option<Vec<Row>> = None;
while let Some(item) = self.try_next().await? {
match (item, &mut result) {
(QueryItem::Row(row), None) => {
result = Some(vec![row]);
}
(QueryItem::Row(row), Some(ref mut result)) => result.push(row),
(QueryItem::Metadata(_), None) => {
result = Some(Vec::new());
}
(QueryItem::Metadata(_), ref mut previous_result) => {
results.push(previous_result.take().unwrap());
result = None;
}
}
}
if let Some(result) = result {
results.push(result);
}
Ok(results)
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions