degroff/file manager #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix copyright dates, and update CSRFProvider interface javadoc to remove reference re: impl.
voidmain
reviewed
Jul 7, 2025
| } | ||
|
|
||
| private String buildResultCode(HTTPProcessingException exception) { | ||
| String name = exception.getClass().getSimpleName().replace("Exception", ""); |
Member
There was a problem hiding this comment.
I think we have this code in a toolkit somewhere. This is how we map actions to URLs. Might want to reuse that code.
| } | ||
|
|
||
| @Test | ||
| public void get_url_rewrite() { |
Member
There was a problem hiding this comment.
You probably should document why this method exists and how we removed the handling for __a_ parameters since it was a large security risk. That way the next person in the code knows the history and doesn't delete this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java-httpand wire up the multipart configuration controls in the action mapper.