Let http server handle most exceptions, and only log unexpected exceptions as error.

Author: robotdan

build.savant

@@ -19,7 +19,7 @@ dropWizardVersion = "3.2.6"
 easyMockVersion = "5.2.0"
 freemarkerVersion = "2.3.32"
 fusionAuthJWTVersion = "5.3.2"
-javaHTTPVersion = "1.1.2-{integration}"
+javaHTTPVersion = "1.2.0-{integration}"
 jsonPatchVersion = "1.13.0"
 guavaVersion = "32.1.2-jre"
 guiceVersion = "6.0.0"

pom.xml

@@ -109,7 +109,7 @@
     <dependency>
       <groupId>io.fusionauth</groupId>
       <artifactId>java-http</artifactId>
-      <version>1.1.2-{integration}</version>
+      <version>1.2.0-{integration}</version>
       <type>jar</type>
       <scope>compile</scope>
       <optional>false</optional>

prime-mvc.iml

@@ -126,11 +126,11 @@
     <orderEntry type="module-library">
       <library>
         <CLASSES>
-          <root url="jar://$USER_HOME$/.savant/cache/io/fusionauth/java-http/1.1.2-{integration}/java-http-1.1.2-{integration}.jar!/" />
+          <root url="jar://$USER_HOME$/.savant/cache/io/fusionauth/java-http/1.2.0-{integration}/java-http-1.2.0-{integration}.jar!/" />
         </CLASSES>
         <JAVADOC />
         <SOURCES>
-          <root url="jar://$USER_HOME$/.savant/cache/io/fusionauth/java-http/1.1.2-{integration}/java-http-1.1.2-{integration}-src.jar!/" />
+          <root url="jar://$USER_HOME$/.savant/cache/io/fusionauth/java-http/1.2.0-{integration}/java-http-1.2.0-{integration}-src.jar!/" />
         </SOURCES>
       </library>
     </orderEntry>

src/main/java/org/primeframework/mvc/BasePrimeMain.java

@@ -123,7 +123,12 @@ public void start() {
 
       // Create the server
       var server = new HTTPServer().withConfiguration(config)
+                                   // Note that by calling each of these methods directly, we are functionally
+                                   // ignoring these three values on the configuration object provided by
+                                   // BasePrimeMain. This just means that the implementor cannot currently
+                                   // provide their own request handler, exception handler or instrumentor.
                                    .withHandler(requestHandler)
+                                   .withUnexpectedExceptionHandler(new PrimeMVCUnexpectedExceptionHandler())
                                    .withInstrumenter(instrumenter);
 
       servers.add(new PrimeHTTPServer(requestHandler, server));

src/main/java/org/primeframework/mvc/PrimeMVCRequestHandler.java

@@ -16,14 +16,12 @@
 package org.primeframework.mvc;
 
 import java.io.Closeable;
-import java.net.SocketException;
 
 import com.google.inject.Injector;
 import io.fusionauth.http.HTTPMethod;
 import io.fusionauth.http.server.HTTPHandler;
 import io.fusionauth.http.server.HTTPRequest;
 import io.fusionauth.http.server.HTTPResponse;
-import io.fusionauth.http.server.io.ConnectionClosedException;
 import org.primeframework.mvc.action.result.MVCWorkflowFinalizer;
 import org.primeframework.mvc.guice.GuiceBootstrap;
 import org.primeframework.mvc.http.HTTPObjectsHolder;
@@ -70,14 +68,12 @@ public void handle(HTTPRequest request, HTTPResponse response) throws Exception
     HTTPObjectsHolder.setRequest(request);
     HTTPObjectsHolder.setResponse(response);
 
+    // Do not catch any exceptions, the HTTP server will handle exceptions.
+    // - If we do want to log or perform any specific handling when an unexpected
+    //   exception is thrown, you may configure an UnexpectedException handler.
+    //   See HTTPServerConfiguration.withUnexpectedExceptionHandler
     try {
       injector.getInstance(MVCWorkflow.class).perform(null);
-    } catch (ConnectionClosedException | SocketException e) {
-      // Catch, ignore and let java-http handle these
-      throw e;
-    } catch (Throwable t) {
-      logger.error("Error encountered", t);
-      throw t; // java-http will cause this error to write back a 500 if possible and close the socket
     } finally {
       HTTPObjectsHolder.clearRequest();
       HTTPObjectsHolder.clearResponse();

src/main/java/org/primeframework/mvc/PrimeMVCUnexpectedExceptionHandler.java

@@ -0,0 +1,33 @@
+/*
+ * Copyright (c) 2025, Inversoft Inc., All Rights Reserved
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
+ * either express or implied. See the License for the specific
+ * language governing permissions and limitations under the License.
+ */
+package org.primeframework.mvc;
+
+import io.fusionauth.http.server.HTTPResponse;
+import io.fusionauth.http.server.HTTPUnexpectedExceptionHandler;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * @author Daniel DeGroff
+ */
+public class PrimeMVCUnexpectedExceptionHandler implements HTTPUnexpectedExceptionHandler {
+  private static final Logger logger = LoggerFactory.getLogger(PrimeMVCUnexpectedExceptionHandler.class);
+
+  @Override
+  public void handle(HTTPResponse response, Throwable t) {
+    logger.error("Error encountered", t);
+  }
+}

src/test/java/org/primeframework/mvc/StaticResourceTest.java

@@ -54,7 +54,7 @@ public void get_classpath_resolution() {
     simulator.test("/org/primeframework/mvc/PrimeMVCRequestHandler.class")
              .get()
              .assertStatusCode(200)
-             .assertContentLength(2939);
+             .assertContentLength(2613);
   }
 
   @Test