Skip to content

Commit 3765db0

Browse files
committed
Simplify transformReceiverAndName()
1 parent 2db7893 commit 3765db0

File tree

1 file changed

+23
-22
lines changed

1 file changed

+23
-22
lines changed

src/transform-node.ts

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -65,20 +65,23 @@ class Transformer extends Source {
6565
}
6666

6767
#transformReceiverAndName(
68-
receiver: angular.AST,
68+
node:
69+
| angular.KeyedRead
70+
| angular.SafeKeyedRead
71+
| angular.PropertyRead
72+
| angular.SafePropertyRead,
6973
property: babel.Expression,
7074
{
7175
computed,
7276
optional,
73-
end = getOuterEnd(property),
7477
hasParentParens = false,
7578
}: {
7679
computed: boolean;
7780
optional: boolean;
78-
end?: number;
7981
hasParentParens?: boolean;
8082
},
8183
) {
84+
const { receiver } = node;
8285
if (
8386
isImplicitThis(receiver, this.#text) ||
8487
receiver.sourceSpan.start === property.start
@@ -103,8 +106,7 @@ class Transformer extends Source {
103106
: isOptionalObject
104107
? { optional: false }
105108
: undefined),
106-
start: getOuterStart(object),
107-
end,
109+
...node.sourceSpan,
108110
},
109111
{ hasParentParens },
110112
);
@@ -272,22 +274,6 @@ class Transformer extends Source {
272274
);
273275
}
274276

275-
if (
276-
node instanceof angular.KeyedRead ||
277-
node instanceof angular.SafeKeyedRead
278-
) {
279-
return this.#transformReceiverAndName(
280-
node.receiver,
281-
this.#transform<babel.Expression>(node.key),
282-
{
283-
computed: true,
284-
optional: node instanceof angular.SafeKeyedRead,
285-
end: node.sourceSpan.end, // ]
286-
hasParentParens: isInParentParens,
287-
},
288-
);
289-
}
290-
291277
if (node instanceof angular.LiteralArray) {
292278
return this.#create<babel.ArrayExpression>(
293279
{
@@ -493,6 +479,21 @@ class Transformer extends Source {
493479
);
494480
}
495481

482+
if (
483+
node instanceof angular.KeyedRead ||
484+
node instanceof angular.SafeKeyedRead
485+
) {
486+
return this.#transformReceiverAndName(
487+
node,
488+
this.#transform<babel.Expression>(node.key),
489+
{
490+
computed: true,
491+
optional: node instanceof angular.SafeKeyedRead,
492+
hasParentParens: isInParentParens,
493+
},
494+
);
495+
}
496+
496497
if (
497498
node instanceof angular.PropertyRead ||
498499
node instanceof angular.SafePropertyRead
@@ -508,7 +509,7 @@ class Transformer extends Source {
508509
? { hasParentParens: isInParentParens }
509510
: {},
510511
);
511-
return this.#transformReceiverAndName(receiver, tName, {
512+
return this.#transformReceiverAndName(node, tName, {
512513
computed: false,
513514
optional: node instanceof angular.SafePropertyRead,
514515
hasParentParens: isInParentParens,

0 commit comments

Comments
 (0)