Skip to content

Additional data in precice-profiling #1

@davidscn

Description

@davidscn

Please describe the problem you are trying to solve.

Our events have the option to commit data, which is not a duration value.

https://github.com/precice/precice/blob/ffe0f992db5b28381ecb5f32ebeec3bd0f4afd52/src/profiling/Event.hpp#L94

However, accessing the generated data through our CLI is not really possible. There is apparently some opportunity so export the data to a csv data frame, but this option is not even documented somewhere.

The event data is useful if you want to connect an event duration to a certain data value, e.g., the size of your rank-local meshes certainly affects the time the mapping requires on this rank. We use this, e.g., in the RBF Solver to track the number of iterations:
https://github.com/precice/precice/blob/ffe0f992db5b28381ecb5f32ebeec3bd0f4afd52/src/mapping/PetRadialBasisFctMapping.hpp#L484

Describe the solution you propose.

We should provide access to this data through the CLI we currently have. I am not sure how this data was treated in previous preCICE versions (or previous versions of our event tool).

We could consider to print something like an EventData table

precice-profiling analyze Fluid --show-data

or simply always give an additional table with the data.

Describe alternatives you've considered

An alternative could be to integrate the table into our 'usual' event timings. The key would then be eventName+key and instead of a duration, the table then contains the data value. However, this becomes problematic if we change units in this table.

Overall, I think having the data more accessible would greatly enhance their application.

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions