Skip to content

Commit e1869c5

Browse files
author
Uttam Rabadiya
committed
Fixed Popover Issues of appending null.
1 parent 111d47a commit e1869c5

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"component library"
1919
],
2020
"license": "MIT",
21-
"version": "2.2.2",
21+
"version": "2.2.3",
2222
"scripts": {
2323
"serve": "vue-cli-service serve",
2424
"build": "vue-cli-service build",

src/components/PCard/PCard.vue

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,14 @@
6262
export default class PCard extends Vue {
6363
6464
/**
65-
* Title content for the card. **Deprecated** Actions will be removed on future releases, use PCardHeader instead props.
65+
* Title content for the card. **Deprecated** Actions will be removed on future releases,
66+
* use PCardHeader instead props.
6667
*/
6768
@Prop({type: String, default: null}) public title!: string;
6869
6970
/**
70-
* Card description. **Deprecated** Actions will be removed on future releases, use PCardHeader instead props.
71+
* Card description. **Deprecated** Actions will be removed on future releases,
72+
* use PCardHeader instead props.
7173
*/
7274
@Prop({type: String, default: null}) public shortDescription!: string;
7375
@@ -84,7 +86,8 @@
8486
@Prop({type: Boolean, default: false}) public sectioned!: boolean;
8587
8688
/**
87-
* Actions for Header. **Deprecated** Actions will be removed on future releases, use PCardHeader instead props.
89+
* Actions for Header. **Deprecated** Actions will be removed on future releases,
90+
* use PCardHeader instead props.
8891
*/
8992
@Prop({type: [Array, String], default: null}) public actions!: [];
9093

src/components/PPopover/PPopover.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ export default class PPopover extends Vue {
137137
}
138138
const popoverOverlay = document.getElementById(this.realId + 'Overlay') as HTMLElement;
139139
const rootElemId = this.$root.$el.id;
140-
if (rootElemId) {
140+
if (rootElemId && popoverOverlay) {
141141
const rootElement = document.getElementById(rootElemId) as HTMLElement;
142142
rootElement.append(popoverOverlay);
143143
this.isAppended = true;

0 commit comments

Comments
 (0)