From 64184881a6a6f86fde52a2c5810950a5a221e33b Mon Sep 17 00:00:00 2001 From: Hivie Date: Tue, 7 Oct 2025 20:24:44 +0100 Subject: [PATCH 1/2] Allow viewing unlisted group pages when in group --- app/Http/Controllers/GroupsController.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/Http/Controllers/GroupsController.php b/app/Http/Controllers/GroupsController.php index a5761fa02f6..6196160354e 100644 --- a/app/Http/Controllers/GroupsController.php +++ b/app/Http/Controllers/GroupsController.php @@ -12,7 +12,8 @@ class GroupsController extends Controller public function show($id) { $group = app('groups')->byIdOrFail($id); - abort_unless($group->hasListing(), 404); + abort_if($group->identifier === 'default', 404); + priv_check('GroupShow', $group)->ensureCan(); $currentMode = default_mode(); $users = $group->users() From f915ad4faa5d6808e7e0785adee050163e21147a Mon Sep 17 00:00:00 2001 From: Hivie Date: Mon, 20 Oct 2025 17:34:07 +0100 Subject: [PATCH 2/2] Use a group that has a listing in SanityTest group factory --- tests/Browser/SanityTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Browser/SanityTest.php b/tests/Browser/SanityTest.php index 90385ab8922..54920bd8c29 100644 --- a/tests/Browser/SanityTest.php +++ b/tests/Browser/SanityTest.php @@ -259,7 +259,7 @@ private static function createScaffolding() ]); // factory for /g/* - self::$scaffolding['group'] = Group::first(); + self::$scaffolding['group'] = Group::where('group_type', 1)->first(); // factory for comments self::$scaffolding['comment'] = Comment::factory()->create([