Skip to content

Commit 0f188a5

Browse files
notbakanekonotbakaneko
authored
Merge branch 'master' into beatmap-es-index-speedup
2 parents 727fab4 + 7f7d9ec commit 0f188a5

40 files changed

+388
-183
lines changed

‎app/Http/Controllers/ArtistTracksController.php‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,25 @@
66
namespace App\Http\Controllers;
77

88
use App\Libraries\Search\ArtistTrackSearch;
9-
use App\Libraries\Search\ArtistTrackSearchParamsFromRequest;
9+
use App\Libraries\Search\ArtistTrackSearchRequestParams;
1010
use App\Models\ArtistTrack;
1111
use App\Transformers\ArtistTrackTransformer;
1212

1313
class ArtistTracksController extends Controller
1414
{
1515
public function index()
1616
{
17-
$params = ArtistTrackSearchParamsFromRequest::fromArray(request()->all());
17+
$params = new ArtistTrackSearchRequestParams(\Request::all());
1818
$search = new ArtistTrackSearch($params);
1919

2020
$tracks = $search->records();
2121
$index = [
22-
'artist_tracks' => json_collection($tracks, new ArtistTrackTransformer(), ['artist', 'album']),
23-
'search' => ArtistTrackSearchParamsFromRequest::toArray($params),
22+
'artist_tracks' => json_collection(
23+
$tracks,
24+
new ArtistTrackTransformer(),
25+
ArtistTrackTransformer::CARD_INCLUDES,
26+
),
27+
'search' => $params->toArray(),
2428
...cursor_for_response($search->getSortCursor()),
2529
];
2630

‎app/Http/Controllers/HomeController.php‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,11 @@ public function search()
184184
$currentUser = Auth::user();
185185
$allSearch = new AllSearch(Request::all(), ['user' => $currentUser]);
186186

187-
if ($allSearch->getMode() === 'beatmapset') {
188-
return ujs_redirect(route('beatmapsets.index', ['q' => $allSearch->getRawQuery()]));
187+
switch ($allSearch->getMode()) {
188+
case 'artist_track':
189+
return ujs_redirect(route('artists.tracks.index', ['query' => $allSearch->getRawQuery()]));
190+
case 'beatmapset':
191+
return ujs_redirect(route('beatmapsets.index', ['q' => $allSearch->getRawQuery()]));
189192
}
190193

191194
$isSearchPage = true;

‎app/Http/Controllers/Teams/ApplicationsController.php‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
use App\Http\Controllers\Controller;
1111
use App\Jobs\Notifications\TeamApplicationReject;
12+
use App\Jobs\Notifications\TeamApplicationStore;
1213
use App\Models\Team;
1314
use App\Models\TeamApplication;
1415
use Symfony\Component\HttpFoundation\Response;
@@ -39,7 +40,7 @@ public function accept(string $teamId, string $id): Response
3940
public function destroy(string $teamId, string $id): Response
4041
{
4142
$currentUser = \Auth::user();
42-
TeamApplication::where('team_id', $teamId)->findOrFail($currentUser->getKey())->delete();
43+
TeamApplication::where('team_id', $teamId)->findOrFail($currentUser->getKey())->cancel();
4344

4445
\Session::flash('popup', osu_trans('teams.applications.destroy.ok'));
4546

@@ -65,7 +66,9 @@ public function store(string $teamId): Response
6566
$team = Team::findOrFail($teamId);
6667
priv_check('TeamApplicationStore', $team)->ensureCan();
6768

68-
$team->applications()->createOrFirst(['user_id' => \Auth::id()]);
69+
$user = \Auth::user();
70+
$application = $team->applications()->createOrFirst(['user_id' => $user->getKey()]);
71+
(new TeamApplicationStore($application, $user))->dispatch();
6972
\Session::flash('popup', osu_trans('teams.applications.store.ok'));
7073

7174
return response(null, 204);

‎app/Jobs/Notifications/BroadcastNotificationBase.php‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ public function handle()
177177
$deliverySettings = static::applyDeliverySettings($receiverIds);
178178

179179
if (empty($deliverySettings)) {
180-
return;
180+
return null;
181181
}
182182

183183
$notification = $this->makeNotification();
@@ -215,6 +215,11 @@ public function handle()
215215
if (!empty($pushReceiverIds)) {
216216
(new NewPrivateNotificationEvent($notification, $pushReceiverIds))->broadcast();
217217
}
218+
219+
return [
220+
'notification' => $notification,
221+
'receiverIds' => $receiverIds,
222+
];
218223
}
219224

220225
public function makeNotification(): Notification

‎app/Jobs/Notifications/TeamApplicationBase.php‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ public function getDetails(): array
3434
{
3535
return [
3636
'cover_url' => $this->team->flag()->url(),
37-
'team_id' => $this->team->getKey(),
3837
'title' => $this->team->name,
3938
];
4039
}

‎app/Jobs/Notifications/TeamApplicationStore.php‎

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
<?php
2+
3+
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the GNU Affero General Public License v3.0.
4+
// See the LICENCE file in the repository root for full licence text.
5+
6+
declare(strict_types=1);
7+
8+
namespace App\Jobs\Notifications;
9+
10+
use App\Models\User;
11+
12+
class TeamApplicationStore extends TeamApplicationBase
13+
{
14+
public function getListeningUserIds(): array
15+
{
16+
return [$this->team->leader_id];
17+
}
18+
19+
public function getDetails(): array
20+
{
21+
return [
22+
...parent::getDetails(),
23+
'title' => User::find($this->userId)?->username ?? '',
24+
];
25+
}
26+
27+
public function handle()
28+
{
29+
$currentAppllication = $this->team->applications()->firstWhere([
30+
'notification_id' => null,
31+
'user_id' => $this->userId,
32+
]);
33+
34+
if ($currentAppllication === null) {
35+
return null;
36+
}
37+
38+
$data = parent::handle();
39+
40+
if ($data !== null) {
41+
$currentAppllication->update(['notification_id' => $data['notification']->getKey()]);
42+
}
43+
44+
return $data;
45+
}
46+
}

‎app/Libraries/Ip2AsnUpdater.php‎

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,32 @@
1212

1313
class Ip2AsnUpdater
1414
{
15+
public static function fetch(Ip $version): string
16+
{
17+
static $baseUrls = [
18+
'https://iptoasn.com/data',
19+
'https://assets.ppy.sh',
20+
];
21+
22+
foreach ($baseUrls as $baseUrl) {
23+
try {
24+
$gz = file_get_contents("{$baseUrl}/ip2asn-{$version->value}.tsv.gz");
25+
26+
if ($gz !== false) {
27+
break;
28+
}
29+
} catch (\Throwable) {
30+
// retry
31+
}
32+
}
33+
34+
if (!isset($gz) || !is_string($gz)) {
35+
throw new \Exception('failed downloading source database');
36+
}
37+
38+
return gzdecode($gz);
39+
}
40+
1541
public static function getDbPath(Ip $version): string
1642
{
1743
return database_path("ip2asn/{$version->value}.tsv");
@@ -60,7 +86,7 @@ private function update(Ip $version, callable $logger): void
6086

6187
if ($newDb) {
6288
$logger('Db file is outdated. Downloading');
63-
$tsv = gzdecode(file_get_contents("https://iptoasn.com/data/ip2asn-{$version->value}.tsv.gz"));
89+
$tsv = static::fetch($version);
6490
} else {
6591
$tsv = file_get_contents($dbPath);
6692
}

‎app/Libraries/Search/ArtistTrackSearch.php‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
use App\Libraries\Elasticsearch\QueryHelper;
1212
use App\Libraries\Elasticsearch\RecordSearch;
1313
use App\Models\ArtistTrack;
14+
use App\Transformers\ArtistTrackTransformer;
1415

1516
class ArtistTrackSearch extends RecordSearch
1617
{
@@ -38,6 +39,11 @@ public function getQuery()
3839
return $query;
3940
}
4041

42+
public function records()
43+
{
44+
return parent::records()->load(ArtistTrackTransformer::CARD_INCLUDES_PRELOAD);
45+
}
46+
4147
private function addExclusiveOnlyFilter(BoolQuery $query): void
4248
{
4349
if ($this->params->exclusiveOnly) {

‎app/Libraries/Search/ArtistTrackSearchParamsFromRequest.php‎

Lines changed: 0 additions & 62 deletions
This file was deleted.

‎app/Libraries/Search/ArtistTrackSearchRequestParams.php‎

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
<?php
2+
3+
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the GNU Affero General Public License v3.0.
4+
// See the LICENCE file in the repository root for full licence text.
5+
6+
declare(strict_types=1);
7+
8+
namespace App\Libraries\Search;
9+
10+
use App\Libraries\Elasticsearch\Utils\ComparatorParam;
11+
use App\Libraries\Elasticsearch\Utils\SearchAfterParam;
12+
13+
class ArtistTrackSearchRequestParams extends ArtistTrackSearchParams
14+
{
15+
public function __construct(array $rawParams)
16+
{
17+
$params = get_params($rawParams, null, [
18+
'album',
19+
'artist',
20+
'bpm:array',
21+
'exclusive_only:bool',
22+
'genre',
23+
'is_default_sort:bool',
24+
'length:array',
25+
'limit:int',
26+
'query',
27+
'sort',
28+
], ['null_missing' => true]);
29+
30+
$this->queryString = presence(trim($params['query'] ?? ''));
31+
$this->album = $params['album'];
32+
$this->artist = $params['artist'];
33+
[$this->bpm, $this->bpmInput] = ComparatorParam::make($params['bpm'], 'float', 0.005);
34+
$this->genre = $params['genre'];
35+
[$this->length, $this->lengthInput] = ComparatorParam::make($params['length'], 'length', 0.5);
36+
$this->parseSort($params['sort'], $params['is_default_sort']);
37+
$this->searchAfter = SearchAfterParam::make($this, cursor_from_params($rawParams)); // TODO: enforce value types
38+
39+
if (isset($params['exclusive_only'])) {
40+
$this->exclusiveOnly = $params['exclusive_only'];
41+
}
42+
}
43+
44+
public function toArray(): array
45+
{
46+
return array_filter([
47+
'album' => $this->album,
48+
'artist' => $this->artist,
49+
'bpm' => $this->bpmInput,
50+
'exclusive_only' => $this->exclusiveOnly,
51+
'genre' => $this->genre,
52+
'is_default_sort' => $this->isDefaultSort,
53+
'length' => $this->lengthInput,
54+
'query' => $this->queryString,
55+
'sort' => "{$this->sortField}_{$this->sortOrder}",
56+
], fn ($value) => $value !== null);
57+
}
58+
}

0 commit comments

Comments
 (0)