Query keeps reloading when using the same key

[hackel]

Hey, I'm stumped trying to figure this out. I've got a fairly straightforward query, and I'm using it in a component that gets recreated in a virtual scroller to render a select box. Whenever I scroll, the query fires again for all the instances of the new component, even though they all have the exact same key. Why might this be happening?

Here's the composable that creates my query. The account passed in is a ref that does not change.

export const useListTerminalsQuery = account => {
    const store = useStore();

    const {
        data: terminals,
        isLoading: isLoadingTerminals,
        ...query
    } = useQuery({
        key: () => TERMINAL_QUERY_KEYS.byRoleForAccount(store.getters.account.role, account.value),
        query: () => api.accounts(account.value).terminals.index({ depots: false }),
        placeholderData: previousData => previousData ?? [],
        staleTime: 4 * 60 * 60 * 1000, // 4 hours
    });

    return {
        ...query,
        isLoadingTerminals,
        terminals,
    };
};

My understanding is that this shouldn't require defineQuery because it is not returning any global state refs. And I can't use it anyway because I need to pass in the account ref to build the query. Correct me if I'm wrong on this or if there's a better way to do this. Thank you!

[posva]

If it’s fully shared, defineQuery will ensure one single version but yours have an argument so it’s better with defineQueryOptions

the refetch might be due to dev mode #320

[hackel]

Aha, I really wasn't familiar with defineQueryOptions. That was the fix. Still a little unclear to me from the docs, but after a little playing around I was able to get it to work fine. Thank you @posva!

[hackel]

Looks like I spoke too soon. Once I finished converting all my invocations of useListTerminalsQuery to use defineQueryOptions, the issue came back. I can confirm that doing a production build "fixes" the refresh issue, but then the query no longer refreshes when I change account for some reason. Still investigating...

[posva]

Sounds like #320