Merge pull request #640 from postmanlabs/feature/fix-non-string-urls

Fixed issue where for non-string URLs, conversion process was failing with TypeError.

Author: VShingala

lib/schemaUtils.js

@@ -367,6 +367,11 @@ module.exports = {
   * @returns {string} string after replacing /{pet}/ with /:pet/
   */
   fixPathVariablesInUrl: function (url) {
+    // URL should always be string so update value if non-string value is found
+    if (typeof url !== 'string') {
+      return '';
+    }
+
     // All complicated logic removed
     // This simply replaces all instances of {text} with {{text}}
     // text cannot have any of these 3 chars: /{}

test/unit/util.test.js

@@ -2654,6 +2654,18 @@ describe('SCHEMA UTILITY FUNCTION TESTS ', function () {
 
       done();
     });
+
+    it('should correctly handle non string values', function(done) {
+      expect(SchemaUtils.fixPathVariablesInUrl(123)).to.equal('');
+
+      expect(SchemaUtils.fixPathVariablesInUrl([])).to.equal('');
+
+      expect(SchemaUtils.fixPathVariablesInUrl({})).to.equal('');
+
+      expect(SchemaUtils.fixPathVariablesInUrl(true)).to.equal('');
+
+      done();
+    });
   });
 
   describe('findPathVariablesFromPath function', function() {