Fixing Schema resolving when it's array type

When schema is array type it will ignore additionalPropeties and resolve as array

Author: erfemega

lib/deref.js

@@ -248,18 +248,6 @@ module.exports = {
       return { value: 'reference ' + schema.$ref + ' not found in the OpenAPI spec' };
     }
 
-    const getAdditionalProperties = (schema) => {
-      let additionalProperties;
-      if (_.isBoolean(schema.additionalProperties)) {
-        additionalProperties = schema.additionalProperties;
-      }
-      else {
-        additionalProperties = this.resolveRefs(schema.additionalProperties, parameterSourceOption,
-          components, schemaResolutionCache, resolveFor, resolveTo, stack, _.cloneDeep(seenRef), stackLimit);
-      }
-      return additionalProperties;
-    };
-
     if (
       concreteUtils.compareTypes(schema.type, SCHEMA_TYPES.object) ||
       schema.hasOwnProperty('properties') ||
@@ -273,7 +261,13 @@ module.exports = {
         // shallow cloning schema object except properties object
 
         if (_.has(schema, 'additionalProperties')) {
-          tempSchema.additionalProperties = getAdditionalProperties(schema);
+          if (_.isBoolean(schema.additionalProperties)) {
+            tempSchema.additionalProperties = schema.additionalProperties;
+          }
+          else {
+            tempSchema.additionalProperties = this.resolveRefs(schema.additionalProperties, parameterSourceOption,
+              components, schemaResolutionCache, resolveFor, resolveTo, stack, _.cloneDeep(seenRef), stackLimit);
+          }
         }
 
         !_.isEmpty(schema.properties) && (tempSchema.properties = {});
@@ -344,10 +338,6 @@ module.exports = {
       // without this, schemas with circular references aren't faked correctly
       let tempSchema = _.omit(schema, ['items', 'additionalProperties']);
 
-      if (_.has(schema, 'additionalProperties')) {
-        tempSchema.additionalProperties = getAdditionalProperties(schema);
-      }
-
       tempSchema.items = this.resolveRefs(schema.items, parameterSourceOption,
         components, schemaResolutionCache, resolveFor, resolveTo, stack, _.cloneDeep(seenRef), stackLimit);
       return tempSchema;