Fixed getOptions related handling for default criteria

Author: VShingala

lib/options.js

@@ -381,12 +381,7 @@ module.exports = {
       if (option.disabled) { return false; }
 
       if (_.isObject(criteria)) {
-        const externalDefault = typeof criteria.external === 'boolean' ? criteria.external : true,
-          usageDefault = ['CONVERSION'];
-
-        (!_.isArray(criteria.usage) || _.isEmpty(criteria.usage)) && (criteria.usage = usageDefault);
-
-        if (option.external !== externalDefault) {
+        if (typeof criteria.external === 'boolean' && option.external !== criteria.external) {
           return false;
         }
 

test/system/structure.test.js

@@ -302,10 +302,8 @@ describe('getOptions', function() {
 describe('OPTIONS.md', function() {
   it('must contain all details of options', function () {
     const optionsDoc = fs.readFileSync('OPTIONS.md', 'utf-8'),
-      v1Options = getOptions(undefined,
-        { usage: ['CONVERSION', 'VALIDATION', 'BUNDLE'], moduleVersion: 'v1' }),
-      v2Options = getOptions(undefined,
-        { usage: ['CONVERSION', 'VALIDATION', 'BUNDLE'], moduleVersion: 'v2' }),
+      v1Options = getOptions(undefined, { external: true, moduleVersion: 'v1' }),
+      v2Options = getOptions(undefined, { external: true, moduleVersion: 'v2' }),
       allOptions = _.uniqBy(_.concat(v1Options, v2Options), 'id');
 
     expect(optionsDoc).to.eql(generateOptionsDoc(allOptions));