Fixed issue where defintions with empty title were converted with empty collection name

VShingala · VShingala · commit af9217d82dc8 · 2023-06-06T12:47:01.000+05:30
diff --git a/lib/schemapack.js b/lib/schemapack.js
@@ -1,7 +1,7 @@
 'use strict';
 
 // This is the default collection name if one can't be inferred from the OpenAPI spec
-const COLLECTION_NAME = 'Imported from OpenAPI 3.0',
+const COLLECTION_NAME = 'Imported from OpenAPI',
   { getConcreteSchemaUtils } = require('./common/versionUtils.js'),
   { convertToOAS30IfSwagger } = require('./swaggerUtils/swaggerToOpenapi.js'),
   BROWSER = 'browser',
@@ -194,12 +194,18 @@ class SchemaPack {
     }
     // if the schema is validated, return the meta data as required.
     else if (this.validated) {
+      let name = _.get(this.openapi, 'info.title');
+
+      if (_.isEmpty(name) || !_.isString(name)) {
+        name = COLLECTION_NAME;
+      }
+
       return cb(null, {
         result: true,
-        name: _.get(this.openapi, 'info.title', COLLECTION_NAME),
+        name: name,
         output: [{
           type: 'collection',
-          name: _.get(this.openapi, 'info.title', COLLECTION_NAME)
+          name: name
         }]
       });
     }
@@ -213,12 +219,18 @@ class SchemaPack {
           return cb(null, validationResult);
         }
 
+        let name = _.get(this.openapi, 'info.title');
+
+        if (_.isEmpty(name) || !_.isString(name)) {
+          name = COLLECTION_NAME;
+        }
+
         return cb(null, {
           result: true,
-          name: _.get(this.openapi, 'info.title', COLLECTION_NAME),
+          name: name,
           output: [{
             type: 'collection',
-            name: _.get(this.openapi, 'info.title', COLLECTION_NAME)
+            name: name
           }]
         });
       });
@@ -336,11 +348,17 @@ class SchemaPack {
         // Fix {scheme} and {path} vars in the URL to :scheme and :path
         openapi.baseUrl = schemaUtils.fixPathVariablesInUrl(openapi.baseUrl);
 
+        let name = _.get(this.openapi, 'info.title');
+
+        if (_.isEmpty(name) || !_.isString(name)) {
+          name = COLLECTION_NAME;
+        }
+
         // Creating a new instance of a Postman collection
         // All generated folders and requests will go inside this
         generatedStore.collection = new sdk.Collection({
           info: {
-            name: _.isEmpty(_.get(openapi, 'info.title')) ? COLLECTION_NAME : _.get(openapi, 'info.title')
+            name: name
           }
         });
 
diff --git a/libV2/helpers/collection/generateCollectionFromOpenAPI.js b/libV2/helpers/collection/generateCollectionFromOpenAPI.js
@@ -1,6 +1,6 @@
 const _ = require('lodash'),
   generateAuthrForCollectionFromOpenAPI = require('./generateAuthForCollectionFromOpenAPI'),
-  COLLECTION_NAME = 'Imported from OpenAPI 3.0',
+  COLLECTION_NAME = 'Imported from OpenAPI',
 
   /**
    * Returns a description that's usable at the collection-level
@@ -93,10 +93,16 @@ module.exports = function ({ openapi }) {
 
   const collectionVariables = resolveCollectionVariablesForBaseUrlFromServersObject(_.get(openapi, 'servers.0'));
 
+  let name = _.get(this.openapi, 'info.title');
+
+  if (_.isEmpty(name) || !_.isString(name)) {
+    name = COLLECTION_NAME;
+  }
+
   return {
     data: {
       info: {
-        name: _.get(openapi, 'info.title', COLLECTION_NAME),
+        name: name,
         description: getCollectionDescription(openapi)
       },
       auth: generateAuthrForCollectionFromOpenAPI(openapi, openapi.security)
diff --git a/test/data/valid_openapi/empty-title.yaml b/test/data/valid_openapi/empty-title.yaml
@@ -0,0 +1,127 @@
+openapi: 3.0.0
+info:
+  version: 1.0.0
+  title: ''
+  license:
+    name: MIT
+servers:
+  - url: http://petstore.swagger.io/v1
+paths:
+  /pets:
+    get:
+      summary: List all pets
+      operationId: listPets
+      tags:
+        - pets
+      parameters:
+        - name: limit
+          in: query
+          description: How many items to return at one time (max 100)
+          required: false
+          schema:
+            type: integer
+            format: int32
+        - name: variable
+          in: query
+          description: random variable
+          style: form
+          explode: false
+          schema:
+            type: array
+            items:
+              type: string
+        - name: variable2
+          in: query
+          description: another random variable
+          style: spaceDelimited
+          schema:
+            type: array
+            items:
+              type: integer
+              format: int64
+      responses:
+        '200':
+          description: An paged array of pets
+          headers:
+            x-next:
+              description: A link to the next page of responses
+              schema:
+                type: string
+          content:
+            application/json:    
+              schema:
+                $ref: "https://postman-echo.com/get"
+        default:
+          description: unexpected error
+          content:
+            application/json:
+              schema:
+                $ref: "#/components/schemas/Error"
+    post:
+      summary: Create a pet
+      operationId: createPets
+      tags:
+        - pets
+      responses:
+        '201':
+          description: Null response
+        default:
+          description: unexpected error
+          content:
+            application/json:
+              schema:
+                $ref: "#/components/schemas/Error"
+  /pets/{petId}:
+    get:
+      summary: Info for a specific pet
+      operationId: showPetById
+      tags:
+        - pets
+      parameters:
+        - name: petId
+          in: path
+          required: true
+          description: The id of the pet to retrieve
+          schema:
+            type: string
+      responses:
+        '200':
+          description: Expected response to a valid request
+          content:
+            application/json:
+              schema:
+                $ref: "#/components/schemas/Pets"
+        default:
+          description: unexpected error
+          content:
+            application/json:
+              schema:
+                $ref: "#/components/schemas/Error"
+components:
+  schemas:
+    Pet:
+      required:
+        - id
+        - name
+      properties:
+        id:
+          type: integer
+          format: int64
+        name:
+          type: string
+        tag:
+          type: string
+    Pets:
+      type: array
+      items:
+        $ref: "#/components/schemas/Pet"
+    Error:
+      required:
+        - code
+        - message
+      properties:
+        code:
+          type: integer
+          format: int32
+        message:
+          type: string
diff --git a/test/unit/base.test.js b/test/unit/base.test.js
@@ -758,6 +758,27 @@ describe('CONVERT FUNCTION TESTS ', function() {
       });
     });
 
+    it('Should return validation result for an definition with empty title field', function(done) {
+      var invalidNoInfo = path.join(__dirname, VALID_OPENAPI_PATH + '/empty-title.yaml'),
+        openapi = fs.readFileSync(invalidNoInfo, 'utf8');
+      Converter.getMetaData({ type: 'json', data: openapi }, (err, status) => {
+        if (err) {
+          expect.fail(null, null, err);
+        }
+        if (status.result) {
+          expect(status.result).to.be.eq(true);
+          expect(status.name).to.be.equal('Imported from OpenAPI');
+          expect(status.output[0].name).to.be.equal('Imported from OpenAPI');
+          expect(status.output[0].type).to.be.equal('collection');
+          done();
+        }
+        else {
+          expect.fail(null, null, status.reason);
+          done();
+        }
+      });
+    });
+
     it('Should return error for more than one root files', function(done) {
       let folderPath = path.join(__dirname, '../data/multiFile_with_two_root'),
         array = [
@@ -2147,6 +2168,25 @@ describe('CONVERT FUNCTION TESTS ', function() {
         done();
       });
     });
+
+    it('Should convert definition with empty title field correctly with default name', function(done) {
+      const fileData = fs.readFileSync(path.join(__dirname, VALID_OPENAPI_PATH, 'empty-title.yaml'), 'utf8'),
+        input = {
+          type: 'string',
+          data: fileData
+        };
+
+      Converter.convert(input, { }, (error, result) => {
+        expect(error).to.be.null;
+        expect(result.result).to.equal(true);
+        expect(result.output.length).to.equal(1);
+        expect(result.output[0].type).to.have.equal('collection');
+        expect(result.output[0].data).to.have.property('info');
+        expect(result.output[0].data.info.name).to.eql('Imported from OpenAPI');
+        expect(result.output[0].data).to.have.property('item');
+        done();
+      });
+    });
   });
 
   describe('requestNameSource option', function() {
diff --git a/test/unit/convertV2.test.js b/test/unit/convertV2.test.js
@@ -2310,4 +2310,23 @@ describe('The convert v2 Function', function() {
         done();
       });
   });
+
+  it('Should convert definition with empty title field correctly with default name', function(done) {
+    const fileData = fs.readFileSync(path.join(__dirname, VALID_OPENAPI_PATH, 'empty-title.yaml'), 'utf8'),
+      input = {
+        type: 'string',
+        data: fileData
+      };
+
+    Converter.convert(input, { }, (error, result) => {
+      expect(error).to.be.null;
+      expect(result.result).to.equal(true);
+      expect(result.output.length).to.equal(1);
+      expect(result.output[0].type).to.have.equal('collection');
+      expect(result.output[0].data).to.have.property('info');
+      expect(result.output[0].data.info.name).to.eql('Imported from OpenAPI');
+      expect(result.output[0].data).to.have.property('item');
+      done();
+    });
+  });
 });
