Merge branch 'develop' into feature/remove-travis

Author: VShingala

OPTIONS.md

@@ -8,7 +8,7 @@ requestParametersResolution|enum|Example, Schema|Schema|Select whether to genera
 exampleParametersResolution|enum|Example, Schema|Example|Select whether to generate the response parameters based on the [schema](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#schemaObject) or the [example](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#exampleObject) in the schema.|CONVERSION
 folderStrategy|enum|Paths, Tags|Paths|Select whether to create folders according to the spec’s paths or tags.|CONVERSION
 schemaFaker|boolean|-|true|Whether or not schemas should be faked.|CONVERSION
-stackLimit|integer|-|10|Number of nesting limit till which schema resolution will happen. Increasing this limit may result in more time to convert collection depending on complexity of specification. (To make sure this option works correctly "optimizeConversion" option needs to be disabled)|CONVERSION
+stackLimit|integer|-|8|Number of nesting limit till which schema resolution will happen. Increasing this limit may result in more time to convert collection depending on complexity of specification. (To make sure this option works correctly "optimizeConversion" option needs to be disabled)|CONVERSION
 includeAuthInfoInExample|boolean|-|true|Select whether to include authentication parameters in the example request|CONVERSION
 shortValidationErrors|boolean|-|false|Whether detailed error messages are required for request <> schema validation operations.|VALIDATION
 validationPropertiesToIgnore|array|-|[]|Specific properties (parts of a request/response pair) to ignore during validation. Must be sent as an array of strings. Valid inputs in the array: PATHVARIABLE, QUERYPARAM, HEADER, BODY, RESPONSE_HEADER, RESPONSE_BODY|VALIDATION

README.md

@@ -1,5 +1,5 @@
 
-![postman icon](https://raw.githubusercontent.com/postmanlabs/postmanlabs.github.io/develop/global-artefacts/postman-logo%2Btext-320x132.png)
+<img src="https://voyager.postman.com/logo/postman-logo-orange.svg" width="320" alt="The Postman Logo">
 
 *Supercharge your API workflow.*
 *Modern software is built on APIs. Postman helps you develop APIs faster.*

lib/deref.js

@@ -149,7 +149,7 @@ module.exports = {
    */
 
   resolveRefs: function (schema, parameterSourceOption, components, schemaResolutionCache,
-    resolveFor = 'CONVERSION', resolveTo = 'schema', stack = 0, seenRef = {}, stackLimit = 10, isAllOf = false) {
+    resolveFor = 'CONVERSION', resolveTo = 'schema', stack = 0, seenRef = {}, stackLimit = 8, isAllOf = false) {
     var resolvedSchema, prop, splitRef,
       ERR_TOO_MANY_LEVELS = '<Error: Too many levels of nesting to fake this schema>';
     let concreteUtils = components && components.hasOwnProperty('concreteUtils') ?

lib/options.js

@@ -155,7 +155,7 @@ module.exports = {
         name: 'Schema resolution nesting limit',
         id: 'stackLimit',
         type: 'integer',
-        default: 10,
+        default: 8,
         description: 'Number of nesting limit till which schema resolution will happen. Increasing this limit may' +
           ' result in more time to convert collection depending on complexity of specification. (To make sure this' +
           ' option works correctly "optimizeConversion" option needs to be disabled)',

lib/schemaUtils.js

@@ -273,7 +273,7 @@ module.exports = {
 
     var computedOptions = _.clone(options);
 
-    computedOptions.stackLimit = 10;
+    computedOptions.stackLimit = 8;
     // This is the score that is given to each spec on the basis of the
     // number of references present in spec and the number of requests that will be generated.
     // This ranges from 0-10.

test/system/structure.test.js

@@ -96,7 +96,7 @@ const optionIds = [
     stackLimit: {
       name: 'Schema resolution nesting limit',
       type: 'integer',
-      default: 10,
+      default: 8,
       description: 'Number of nesting limit till which schema resolution will happen. Increasing this limit may' +
         ' result in more time to convert collection depending on complexity of specification. (To make sure this' +
         ' option works correctly "optimizeConversion" option needs to be disabled)'

test/unit/validator.test.js

@@ -1349,7 +1349,7 @@ describe('VALIDATE FUNCTION TESTS ', function () {
         '/invalid_response_body_all_of_properties_collection.json'), 'utf-8'),
       historyRequest = [],
       schemaPack = new Converter.SchemaPack({ type: 'string', data: allOfExample },
-        { suggestAvailableFixes: true, showMissingInSchemaErrors: true });
+        { suggestAvailableFixes: true, showMissingInSchemaErrors: true, optimizeConversion: false, stackLimit: 10 });
 
     getAllTransactions(JSON.parse(allOfCollection), historyRequest);