Addressed comments

Author: VShingala

lib/schemapack.js

@@ -1,8 +1,6 @@
 'use strict';
 
-// This is the default collection name if one can't be inferred from the OpenAPI spec
-const COLLECTION_NAME = 'Imported from OpenAPI',
-  { getConcreteSchemaUtils } = require('./common/versionUtils.js'),
+const { getConcreteSchemaUtils } = require('./common/versionUtils.js'),
   { convertToOAS30IfSwagger } = require('./swaggerUtils/swaggerToOpenapi.js'),
   BROWSER = 'browser',
   Ajv = require('ajv'),
@@ -194,11 +192,7 @@ class SchemaPack {
     }
     // if the schema is validated, return the meta data as required.
     else if (this.validated) {
-      let name = _.get(this.openapi, 'info.title');
-
-      if (_.isEmpty(name) || !_.isString(name)) {
-        name = COLLECTION_NAME;
-      }
+      let name = utils.getCollectionName(_.get(this.openapi, 'info.title'));
 
       return cb(null, {
         result: true,
@@ -219,11 +213,7 @@ class SchemaPack {
           return cb(null, validationResult);
         }
 
-        let name = _.get(this.openapi, 'info.title');
-
-        if (_.isEmpty(name) || !_.isString(name)) {
-          name = COLLECTION_NAME;
-        }
+        let name = utils.getCollectionName(_.get(this.openapi, 'info.title'));
 
         return cb(null, {
           result: true,
@@ -348,17 +338,11 @@ class SchemaPack {
         // Fix {scheme} and {path} vars in the URL to :scheme and :path
         openapi.baseUrl = schemaUtils.fixPathVariablesInUrl(openapi.baseUrl);
 
-        let name = _.get(this.openapi, 'info.title');
-
-        if (_.isEmpty(name) || !_.isString(name)) {
-          name = COLLECTION_NAME;
-        }
-
         // Creating a new instance of a Postman collection
         // All generated folders and requests will go inside this
         generatedStore.collection = new sdk.Collection({
           info: {
-            name: name
+            name: utils.getCollectionName(_.get(openapi, 'info.title'))
           }
         });
 

lib/utils.js

@@ -1,4 +1,7 @@
-const _ = require('lodash');
+const _ = require('lodash'),
+
+  // This is the default collection name if one can't be inferred from the OpenAPI spec
+  COLLECTION_NAME = 'Imported from OpenAPI';
 
 // this will have non-OAS-related utils
 
@@ -142,5 +145,19 @@ module.exports = {
       res.push(segment);
     }
     return res.join('/');
+  },
+
+  /**
+   * Provides collection name to be used for generated collection
+   *
+   * @param {*} title - Definition title
+   * @returns {String} - Collection name
+   */
+  getCollectionName: function (title) {
+    if (_.isEmpty(title) || !_.isString(title)) {
+      return COLLECTION_NAME;
+    }
+
+    return title;
   }
 };

libV2/helpers/collection/generateCollectionFromOpenAPI.js

@@ -1,6 +1,6 @@
 const _ = require('lodash'),
+  utils = require('../../utils'),
   generateAuthrForCollectionFromOpenAPI = require('./generateAuthForCollectionFromOpenAPI'),
-  COLLECTION_NAME = 'Imported from OpenAPI',
 
   /**
    * Returns a description that's usable at the collection-level
@@ -93,16 +93,10 @@ module.exports = function ({ openapi }) {
 
   const collectionVariables = resolveCollectionVariablesForBaseUrlFromServersObject(_.get(openapi, 'servers.0'));
 
-  let name = _.get(openapi, 'info.title');
-
-  if (_.isEmpty(name) || !_.isString(name)) {
-    name = COLLECTION_NAME;
-  }
-
   return {
     data: {
       info: {
-        name: name,
+        name: utils.getCollectionName(_.get(openapi, 'info.title')),
         description: getCollectionDescription(openapi)
       },
       auth: generateAuthrForCollectionFromOpenAPI(openapi, openapi.security)

libV2/utils.js

@@ -1,5 +1,8 @@
 const sdk = require('postman-collection'),
   _ = require('lodash'),
+
+  // This is the default collection name if one can't be inferred from the OpenAPI spec
+  COLLECTION_NAME = 'Imported from OpenAPI',
   generatePmResponseObject = (response) => {
     const requestItem = generateRequestItemObject({ // eslint-disable-line no-use-before-define
         request: response.originalRequest
@@ -182,6 +185,20 @@ module.exports = {
     return _.isString(url) ? url.replace(/(\{[^\/\{\}]+\})/g, replacer) : '';
   },
 
+  /**
+   * Provides collection name to be used for generated collection
+   *
+   * @param {*} title - Definition title
+   * @returns {String} - Collection name
+   */
+  getCollectionName: function (title) {
+    if (_.isEmpty(title) || !_.isString(title)) {
+      return COLLECTION_NAME;
+    }
+
+    return title;
+  },
+
   generatePmResponseObject,
   generateRequestItemObject
 };