Merge pull request #573 from postmanlabs/fix/518-enumFakedAsNaN

Fix #518 integer query params with enum values get default value of NaN

Author: VShingala

assets/json-schema-faker.js

@@ -23782,7 +23782,7 @@ function extend() {
                   var min = Math.max(params.minimum || 0, 0);
                   var max = Math.min(params.maximum || Infinity, Infinity);
                   min = handleExclusiveMinimum(schema, min);
-                  max = handleExclusiveMaximum(schema, min);
+                  max = handleExclusiveMaximum(schema, max);
                   // discard out-of-bounds enumerations
                   schema.enum = schema.enum.filter(function (x) {
                       if (x >= min && x <= max) {

test/data/valid_openapi/query_param_with_enum_resolve_as_example.json

@@ -0,0 +1,51 @@
+{
+	"openapi": "3.1.0",
+	"info": {
+		"version": "1.0.0",
+		"title": "Swagger Petstore",
+		"license": {
+			"name": "MIT"
+		}
+	},
+	"servers": [
+		{
+			"url": "http://petstore.swagger.io/v1"
+		}
+	],
+	"paths": {
+		"/foo": {
+			"get": {
+				"parameters": [
+					{
+						"name": "foo",
+						"in": "query",
+						"required": true,
+						"schema": {
+								"type": "integer",
+								"enum": [120]
+						}
+					}
+				],
+				"responses": {}
+			}
+		}
+	},
+	"components": {
+		"schemas": {
+			"Pet": {
+        "type": "object",
+				"properties": {
+					"id": {
+						"type": "integer",
+            "format": "int64",
+            "description": "Description of Pet ID"
+          },
+          "name": {
+            "type": "string",
+            "description": "Description of Pet name"
+          }
+				}
+      }
+		}
+	}
+}

test/unit/base.test.js

@@ -51,6 +51,8 @@ describe('CONVERT FUNCTION TESTS ', function() {
       deepObjectLengthProperty = path.join(__dirname, VALID_OPENAPI_PATH, '/deepObjectLengthProperty.yaml'),
       valuePropInExample = path.join(__dirname, VALID_OPENAPI_PATH, '/valuePropInExample.yaml'),
       petstoreParamExample = path.join(__dirname, VALID_OPENAPI_PATH, '/petstoreParamExample.yaml'),
+      queryParamWithEnumResolveAsExample =
+        path.join(__dirname, VALID_OPENAPI_PATH, '/query_param_with_enum_resolve_as_example.json'),
       formDataParamDescription = path.join(__dirname, VALID_OPENAPI_PATH, '/form_data_param_description.yaml'),
       allHTTPMethodsSpec = path.join(__dirname, VALID_OPENAPI_PATH, '/all-http-methods.yaml');
 
@@ -1144,6 +1146,23 @@ describe('CONVERT FUNCTION TESTS ', function() {
         });
     });
 
+    it('[Github #518]- integer query params with enum values get default value of NaN' +
+    descriptionInBodyParams, function(done) {
+      var openapi = fs.readFileSync(queryParamWithEnumResolveAsExample, 'utf8');
+      Converter.convert({
+        type: 'string',
+        data: openapi
+      }, {
+        schemaFaker: true,
+        requestParametersResolution: 'Example'
+      }, (err, conversionResult) => {
+        let fakedParam = conversionResult.output[0].data.item[0].request.url.query[0].value;
+        expect(err).to.be.null;
+        expect(fakedParam).to.be.equal('120');
+        done();
+      });
+    });
+
     it('[Github #559]Should convert description in form data parameters' +
     petstoreParamExample, function(done) {
       var openapi = fs.readFileSync(formDataParamDescription, 'utf8');